From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] libsensors: Add support for extra fan attributes
Date: Fri, 13 Jan 2012 15:21:46 +0000 [thread overview]
Message-ID: <20120113162146.45a04af7@endymion.delvare> (raw)
In-Reply-To: <20120113155100.1e081f29@endymion.delvare>
On Fri, 13 Jan 2012 07:13:36 -0800, Guenter Roeck wrote:
> On Fri, Jan 13, 2012 at 09:51:00AM -0500, Jean Delvare wrote:
> > Add support for fan[1-*]_max, fan[1-*]_min_alarm and fan[1-*]_max_alarm
> > attributes. These are defined in the standard sysfs interface for quite
> > some time, and at least three drivers (max6650, lm63 and applesmc)
> > implement them so we should support them.
> > ---
> > doc/libsensors-API.txt | 3 +++
> > lib/sensors.h | 3 +++
> > lib/sysfs.c | 3 +++
> > prog/sensors/chips.c | 38 +++++++++++++++++++++++++-------------
> > 4 files changed, 34 insertions(+), 13 deletions(-)
> >
> Looks good.
>
> Maybe I should try to re-do that using the table based generic code. Wonder why I didn't earlier.
To be honest, I considered it first, and then saw that it was broken,
so we should fix it first. But lacking the time and energy to do that
today, I took the short path to where I needed to go.
The problem I see in the generic code is with power limits, "interval"
is considered a limit and will thus be printed with unit "W" instead of
"s". Likewise fan[1-*]_div would show up with unit RPM which is no
good. Apparently we need a way to force unit (or lack thereof) on a
per-limit basis. Maybe we can leverage the work done for temperatures
(°C vs. °F), but I'm not sure.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-01-13 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 14:51 [lm-sensors] [PATCH] libsensors: Add support for extra fan attributes Jean Delvare
2012-01-13 15:13 ` Guenter Roeck
2012-01-13 15:21 ` Jean Delvare [this message]
2012-01-13 16:04 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113162146.45a04af7@endymion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.