From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] PCI changes
Date: Fri, 13 Jan 2012 21:24:09 +0000 [thread overview]
Message-ID: <20120113212409.GA27671@srcf.ucam.org> (raw)
In-Reply-To: <CA+55aFwDVEH1NwEgKCQSv9ee3P2ma1aqtjOo-s2BeURyeTGo8g@mail.gmail.com>
On Wed, Jan 11, 2012 at 07:38:25PM -0800, Linus Torvalds wrote:
> On Wed, Jan 11, 2012 at 10:34 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >
> > Matthew Garrett (1):
> > PCI: Rework ASPM disable code
>
> Yay.
>
> However, looking this through some more, I'm still a bit confused by
> the pcie_clear_aspm() call in acpi_pci_root_add().
>
> It seems to be explicitly against the rules elsewhere - we clear ASPM
> even though ACPI_FADT_NO_ASPM is set - which the changelog (and the
> other parts of that commit) says means "don't touch pre-existing ASPM
> state").
>
> So why is acpi_pci_root_add() special? Cna you explain that part to me?
pcie_no_aspm() means "Do not permit ASPM to be enabled" - it doesn't
alter the existing state. pcie_clear_aspm() does that.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-01-13 21:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 18:34 [git pull] PCI changes Jesse Barnes
2012-01-12 3:38 ` Linus Torvalds
2012-01-13 21:24 ` Matthew Garrett [this message]
2012-01-13 23:14 ` Linus Torvalds
2012-01-13 23:26 ` Matthew Garrett
2012-01-12 5:34 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2011-10-28 20:29 Jesse Barnes
2011-10-28 23:30 ` Rafael J. Wysocki
2011-10-31 17:18 ` Jesse Barnes
2011-07-28 23:51 Jesse Barnes
2011-05-23 20:43 Jesse Barnes
2011-05-23 21:16 ` David Miller
2011-05-24 0:04 ` Jesse Barnes
2011-03-18 17:30 Jesse Barnes
2011-01-14 17:01 Jesse Barnes
2010-08-05 19:52 Jesse Barnes
2010-05-21 21:48 Jesse Barnes
2010-05-22 0:12 ` Linus Torvalds
2010-05-22 1:59 ` Linus Torvalds
2010-05-22 3:01 ` Jesse Barnes
2010-05-22 8:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113212409.GA27671@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.