From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU
Date: Sat, 14 Jan 2012 00:13:10 +0100 [thread overview]
Message-ID: <20120113231310.8EADD11CDEDB@gemini.denx.de> (raw)
In-Reply-To: <1326396641-20928-1-git-send-email-galak@kernel.crashing.org>
Dear Kumar Gala,
In message <1326396641-20928-1-git-send-email-galak@kernel.crashing.org> you wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> post/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/post/Makefile b/post/Makefile
> index 200e2f1..55b7d21 100644
> --- a/post/Makefile
> +++ b/post/Makefile
> @@ -32,7 +32,7 @@ COBJS-$(CONFIG_POST_STD_LIST) += tests.o
> SPLIB-$(CONFIG_HAS_POST) = drivers/libpostdrivers.o
> SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH) ]; then echo \
> "lib_$(ARCH)/libpost$(ARCH).o"; fi)
> -SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
> +SPLIB-$(CONFIG_SYS_POST_FPU) += $(shell if [ -d lib_$(ARCH)/fpu ]; then echo \
> "lib_$(ARCH)/fpu/libpost$(ARCH)fpu.o"; fi)
> SPLIB-$(CONFIG_HAS_POST) += $(shell if [ -d cpu/$(CPU) ]; then echo \
> "cpu/$(CPU)/libpost$(CPU).o"; fi)
Unfortunately I applied this patch without sufficient tesing. It
breaks a number of boards:
Configuring for korat board...
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for korat_perm - Board: korat, Options: KORAT_PERMANENT
post/libpost.o:(.data.rel.post_list+0xb0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for lwmon5 board...
post/libpost.o:(.data.rel.post_list+0xf0): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia - Board: sequoia, Options: SEQUOIA
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_nand - Board: sequoia, Options: SEQUOIA,NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for sequoia_ramboot - Board: sequoia, Options: SEQUOIA,SYS_RAMBOOT,SYS_TEXT_BASE=0x01000000,SYS_LDSCRIPT=board/amcc/sequoia/u-boot-ram.lds
post/libpost.o:(.data.rel.post_list+0x70): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Configuring for PMC440 board...
post/libpost.o:(.data.rel.post_list+0x90): undefined reference to `fpu_post_test'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
powerpc-linux-size: '/work/wd/tmp-ppc/u-boot': No such file
Please provide a fix. Alternatively I can revert that patch.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life. Don't talk to me about life. - Marvin the Paranoid Android
next prev parent reply other threads:[~2012-01-13 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 19:30 [U-Boot] [PATCH] post/Makefile: Only build FP post tests if enabled via CONFIG_SYS_POST_FPU Kumar Gala
2012-01-13 19:42 ` Wolfgang Denk
2012-01-13 23:13 ` Wolfgang Denk [this message]
2012-03-04 0:04 ` Wolfgang Denk
2012-03-05 5:56 ` Marek Vasut
2012-03-12 14:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113231310.8EADD11CDEDB@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.