From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] miiphyutil: Add Micrel KSZ9021 support to miiphy_speed
Date: Sat, 14 Jan 2012 19:56:39 -0500 [thread overview]
Message-ID: <201201141956.40778.vapier@gentoo.org> (raw)
In-Reply-To: <1326456604-25137-3-git-send-email-dirk.behme@de.bosch.com>
On Friday 13 January 2012 07:10:02 Dirk Behme wrote:
> common/miiphyutil.c | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
this is dead code ... i think we're pushing people to use the name phy
framework rather than fixing/extending the old one.
> --- a/common/miiphyutil.c
> +++ b/common/miiphyutil.c
>
> +#ifdef CONFIG_PHY_MICREL_KSZ9021
> +#define MII_PHY_CTL 0x1f
> +#define MII_PHY_CTL_1000 (1 << 6)
> +#define MII_PHY_CTL_100 (1 << 5)
> +#define MII_PHY_CTL_10 (1 << 4)
are you sure there aren't defines already in linux/mii.h for these ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120114/127e8846/attachment.pgp>
next prev parent reply other threads:[~2012-01-15 0:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 12:10 [U-Boot] [PATCH 1/5] net: fec_mxc: Add 1000 Mbps selection Dirk Behme
2012-01-13 12:10 ` [U-Boot] [PATCH 2/5] net: fec_mxc: Increase autonegotiation timeout Dirk Behme
2012-01-13 12:10 ` [U-Boot] [PATCH 3/5] miiphyutil: Add Micrel KSZ9021 support to miiphy_speed Dirk Behme
2012-01-13 12:44 ` Marek Vasut
2012-01-15 0:56 ` Mike Frysinger [this message]
2012-01-19 12:38 ` Dirk Behme
2012-01-19 16:19 ` Dirk Behme
2012-01-19 18:24 ` Mike Frysinger
2012-01-19 18:24 ` Mike Frysinger
2012-01-19 12:27 ` Dirk Behme
2012-01-13 12:10 ` [U-Boot] [PATCH 4/5] net: fec_mxc: Nove autonegoatiate restart after mii_postcall Dirk Behme
2012-01-13 12:44 ` Marek Vasut
2012-01-13 21:42 ` Troy Kisky
2012-01-13 13:54 ` Stefano Babic
2012-01-13 21:22 ` Troy Kisky
2012-01-13 12:10 ` [U-Boot] [PATCH 5/5] i.mx6q: mx6qsabrelite: Update the network configuration Dirk Behme
2012-01-16 13:48 ` Jason Hui
2012-01-16 19:51 ` Troy Kisky
2012-01-13 12:42 ` [U-Boot] [PATCH 1/5] net: fec_mxc: Add 1000 Mbps selection Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201141956.40778.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.