All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] i.mx6q: SabreLite: Add SPI NOR support
Date: Sat, 14 Jan 2012 20:05:49 -0500	[thread overview]
Message-ID: <201201142005.50057.vapier@gentoo.org> (raw)
In-Reply-To: <201201121638.40178.marek.vasut@gmail.com>

On Thursday 12 January 2012 10:38:40 Marek Vasut wrote:
> > From: Eric Nelson <eric.nelson@boundarydevices.com>
> > +#ifdef CONFIG_IMX_ECSPI
> > +s32 spi_get_cfg(struct imx_spi_dev_t *dev)
> > +{
> > +	int rval = 0 ;
> > +	if (1 == dev->slave.cs) {
> > +		dev->base = ECSPI1_BASE_ADDR;
> > +		dev->ss = 1 ;
> 
> " ;" again.
> 
> Also, Do you even need the ecspi thing? Doesn't uboot support some kind of
> imx spi driver already?

when you reply, please delete all unnecessary context.  there was like ~170 
lines of context when you only needed ~10.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120114/79a08313/attachment.pgp>

  parent reply	other threads:[~2012-01-15  1:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12 15:27 [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver Dirk Behme
2012-01-12 15:27 ` [U-Boot] [PATCH 2/2] i.mx6q: SabreLite: Add SPI NOR support Dirk Behme
2012-01-12 15:32   ` Fabio Estevam
2012-01-12 15:38   ` Marek Vasut
2012-01-12 15:48     ` Fabio Estevam
2012-01-13  7:19       ` Dirk Behme
2012-01-15  1:05     ` Mike Frysinger [this message]
2012-01-15  1:04   ` Mike Frysinger
2012-01-12 15:37 ` [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver Marek Vasut
2012-01-13  7:32   ` Dirk Behme
2012-01-13 12:17     ` Marek Vasut
2012-01-12 15:40 ` Fabio Estevam
2012-01-13 10:48 ` Stefano Babic
2012-01-13 11:45   ` Dirk Behme
2012-01-16 17:29     ` Eric Nelson
2012-01-16 17:38       ` Stefano Babic
2012-01-15  1:04 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201142005.50057.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.