From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jhbird.choi@samsung.com, Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] mfd: variable dereferenced before check
Date: Sun, 15 Jan 2012 03:15:55 -0800 [thread overview]
Message-ID: <20120115111553.GA3040@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326418852-19378-1-git-send-email-jhbird.choi@samsung.com>
On Fri, Jan 13, 2012 at 10:40:52AM +0900, jhbird.choi@samsung.com wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Remove "wm8350->irq_base = pdata->irq_base" to avoid
> null pointer exception and wm8350->irq_base got from
> irq_alloc_descs().
Always send patches to the relevant maintainers - for the MFD subsystem
the maintainer is Samuel Ortiz.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/mfd/wm8350-irq.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
> index 8a1fafd..9fd01bf 100644
> --- a/drivers/mfd/wm8350-irq.c
> +++ b/drivers/mfd/wm8350-irq.c
> @@ -496,7 +496,6 @@ int wm8350_irq_init(struct wm8350 *wm8350, int irq,
>
> mutex_init(&wm8350->irq_lock);
> wm8350->chip_irq = irq;
> - wm8350->irq_base = pdata->irq_base;
>
> if (pdata && pdata->irq_base > 0)
> irq_base = pdata->irq_base;
> --
> 1.7.1
>
next prev parent reply other threads:[~2012-01-15 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 1:40 [PATCH] mfd: variable dereferenced before check jhbird.choi
2012-01-15 11:15 ` Mark Brown [this message]
2012-02-20 15:15 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120115111553.GA3040@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jhbird.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.