All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [Regression] Commit "tpm: Introduce function to poll for result of self test" breaks suspend
Date: Mon, 16 Jan 2012 00:22:07 +0100	[thread overview]
Message-ID: <201201160022.07176.rjw@sisk.pl> (raw)

Hi Stefan,

Unfortunately, the following commit from you:

commit 68d6e6713fcb2ea6278661aaaf5f1c9c821b3751
Author: Stefan Berger <stefanb@linux.vnet.ibm.com>
Date:   Fri Nov 11 12:57:04 2011 -0500

    tpm: Introduce function to poll for result of self test
    
    This patch introduces a function that runs the TPM_ContinueSelfTest()
    function and then polls the TPM to check whether it finished the selftest
    and can receive new commands.
    
    Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

broke suspend on my Toshiba Portege R500.  It causes the tpm driver to
return an error code from .suspend() on every attempt to suspend the system.

Revertig this commit on top of the current Linus' tree fixes the problem for me.

If necessary, I'll collect more information about this problem tomorrow.

Thanks,
Rafael

             reply	other threads:[~2012-01-15 23:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 23:22 Rafael J. Wysocki [this message]
2012-01-16  2:27 ` [Regression] Commit "tpm: Introduce function to poll for result of self test" breaks suspend Stefan Berger
2012-01-16 20:42   ` Rafael J. Wysocki
2012-01-16 21:15     ` Stefan Berger
2012-01-16 22:05       ` Rafael J. Wysocki
2012-01-16 22:43         ` Stefan Berger
2012-01-16 22:50           ` Rafael J. Wysocki
2012-01-16 23:50             ` Stefan Berger
2012-01-17 22:13               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201160022.07176.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.