From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] x86/mm: Improve ring management for memory events. Do not lose guest events Date: Mon, 16 Jan 2012 16:10:58 +0100 Message-ID: <20120116151058.GC30327@aepfle.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com, tim@xen.org, adin@gridcentric.ca List-Id: xen-devel@lists.xenproject.org On Wed, Jan 11, Andres Lagar-Cavilla wrote: > xen/arch/x86/hvm/hvm.c | 18 +- > xen/arch/x86/mm/mem_event.c | 298 +++++++++++++++++++++++++++++++++------ > xen/arch/x86/mm/mem_sharing.c | 30 +-- > xen/arch/x86/mm/p2m.c | 81 +++++----- > xen/common/memory.c | 7 +- > xen/include/asm-x86/mem_event.h | 22 +- > xen/include/asm-x86/p2m.h | 12 +- > xen/include/xen/mm.h | 2 + > xen/include/xen/sched.h | 22 ++- > 9 files changed, 359 insertions(+), 133 deletions(-) > > > This patch is an amalgamation of the work done by Olaf Hering > and our work. > > It combines logic changes to simplify the memory event API, as well as > leveraging wait queues to deal with extreme conditions in which too many events are > generated by a guest vcpu. I'm ok with the approach, and it looks like the approach does not conflict with my attempt to use waitqueues in get_gfn_type_access(). If the ring is full, the vcpu is put in a wait queue. Olaf