From: Olaf Hering <olaf@aepfle.de>
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com,
tim@xen.org, adin@gridcentric.ca
Subject: Re: [PATCH] x86/mm: Improve ring management for memory events. Do not lose guest events
Date: Mon, 16 Jan 2012 16:41:16 +0100 [thread overview]
Message-ID: <20120116154116.GA31139@aepfle.de> (raw)
In-Reply-To: <28c68de1ea253d7dbe34.1326728344@xdev.gridcentric.ca>
On Mon, Jan 16, Andres Lagar-Cavilla wrote:
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -480,16 +480,15 @@ int p2m_mem_paging_evict(struct domain *
> /* Tell xenpaging to drop a paged out frame */
> void p2m_mem_paging_drop_page(struct domain *d, unsigned long gfn);
> /* Start populating a paged out frame */
> -void p2m_mem_paging_populate(struct domain *d, unsigned long gfn);
> +int p2m_mem_paging_populate(struct domain *d, unsigned long gfn);
As I said, this should remain void because the callers cant possibly
care about errors.
Olaf
next prev parent reply other threads:[~2012-01-16 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 15:39 [PATCH] x86/mm: Improve ring management for memory events. Do not lose guest events Andres Lagar-Cavilla
2012-01-16 15:41 ` Olaf Hering [this message]
2012-01-19 10:39 ` Tim Deegan
-- strict thread matches above, loose matches on Subject: below --
2012-01-11 18:28 Andres Lagar-Cavilla
2012-01-12 11:56 ` Tim Deegan
2012-01-12 16:05 ` Andres Lagar-Cavilla
2012-01-13 9:50 ` Olaf Hering
2012-01-13 15:14 ` Andres Lagar-Cavilla
2012-01-13 19:57 ` Olaf Hering
2012-01-13 20:05 ` Andres Lagar-Cavilla
2012-01-16 15:08 ` Olaf Hering
2012-01-16 16:22 ` Olaf Hering
2012-01-16 15:04 ` Olaf Hering
2012-01-16 15:08 ` Andres Lagar-Cavilla
2012-01-16 15:10 ` Olaf Hering
2012-01-16 15:22 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116154116.GA31139@aepfle.de \
--to=olaf@aepfle.de \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=andres@lagarcavilla.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.