From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] x86/mm: Improve ring management for memory
 events. Do not lose guest events
Date: Mon, 16 Jan 2012 17:22:29 +0100
Message-ID: <20120116162229.GA32190@aepfle.de>
References: <a85e7d46401b1d419629.1326306504@xdev.gridcentric.ca>
	<20120113095022.GA18130@aepfle.de>
	<873a666b95bbe7e50992fb1059bc2220.squirrel@webmail.lagarcavilla.org>
	<20120113195706.GA26566@aepfle.de>
	<c7c228ea2fa1f07ffbdfbb167bec5152.squirrel@webmail.lagarcavilla.org>
	<20120116150801.GB30327@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20120116150801.GB30327@aepfle.de>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Cc: andres@gridcentric.ca, xen-devel@lists.xensource.com, tim@xen.org, adin@gridcentric.ca
List-Id: xen-devel@lists.xenproject.org

On Mon, Jan 16, Olaf Hering wrote:

> I will prepare a patch to improve the check wether the ring is
> available. As you said, it can disappear any time.

Your changes to mem_event_disable() already contain the changes I would
have made as well, making changes only with the ring lock held.

Minor detail:
In mem_event_enable(), the call to mem_event_ring_lock_init() should be
moved up before the pointers are assigned to close the tiny window
between lock init and assignment.

Olaf