From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [V3 3/6] RTC: sa1100: support sa1100, pxa and mmp soc families
Date: Mon, 16 Jan 2012 16:50:52 +0100 [thread overview]
Message-ID: <201201161650.52283.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111130135710.GC18533@game.jcrosoft.org>
> On 14:30 Wed 30 Nov , Jett.Zhou wrote:
> > Since the regmap of rtc on sa1100, pxa and mmp Marvell soc families are
> > almost the same, so re-arch the rtc-sa1100 to support them.
> >
> > Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
> > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> just one comment
>
> > ---
> >
> > arch/arm/mach-pxa/devices.c | 20 +++
> > arch/arm/mach-sa1100/generic.c | 20 +++
> > drivers/rtc/Kconfig | 2 +-
> > drivers/rtc/rtc-sa1100.c | 256
> > +++++++++++++++++++++++++++------------ 4 files changed, 218
> > insertions(+), 80 deletions(-)
> >
> > diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c
> > index 2e04254..8b134c3 100644
> > --- a/arch/arm/mach-pxa/devices.c
> > +++ b/arch/arm/mach-pxa/devices.c
> > @@ -415,9 +415,29 @@ static struct resource pxa_rtc_resources[] = {
> >
> > },
> >
> > };
> >
> > +static struct resource sa1100_rtc_resources[] = {
> > + [0] = {
> > + .start = 0x40900000,
> > + .end = 0x409000ff,
> > + .flags = IORESOURCE_MEM,
> > + },
> > + [1] = {
> > + .start = IRQ_RTC1Hz,
> > + .end = IRQ_RTC1Hz,
> > + .flags = IORESOURCE_IRQ,
> > + },
> > + [2] = {
> > + .start = IRQ_RTCAlrm,
> > + .end = IRQ_RTCAlrm,
> > + .flags = IORESOURCE_IRQ,
> > + },
>
> please the MACRO
What? You mean "use uppercase" ?
>
> Best Regards,
> J
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-01-16 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 6:30 [V3 3/6] RTC: sa1100: support sa1100, pxa and mmp soc families Jett.Zhou
2011-11-30 13:57 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-16 15:50 ` Marek Vasut [this message]
2012-01-16 16:10 ` Russell King - ARM Linux
2012-01-14 9:27 ` Russell King - ARM Linux
2012-01-16 0:38 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201161650.52283.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.