From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Only look for matching clocks for LVDS downclock Date: Mon, 16 Jan 2012 21:21:45 +0100 Message-ID: <20120116202145.GF3627@phenom.ffwll.local> References: <1326236976-7669-1-git-send-email-seanpaul@chromium.org> <20120116122003.576348dc@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AF999E8B6 for ; Mon, 16 Jan 2012 12:21:51 -0800 (PST) Received: by wgbdr11 with SMTP id dr11so1882871wgb.12 for ; Mon, 16 Jan 2012 12:21:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <20120116122003.576348dc@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 16, 2012 at 12:20:03PM -0800, Jesse Barnes wrote: > On Tue, 10 Jan 2012 15:09:36 -0800 > Sean Paul wrote: > > > This patch enforces that the downclock clock source is the same as the preferred > > clock source for LVDS. This fixes a bug where the driver chooses a downclock > > clock source with a different P than the preferred mode clock source. This > > happened even if the preferred clock source implemented an acceptable rate for > > the downclock. The result of this bug is that downclock is disabled. > > > > Signed-off-by: Sean Paul > > --- > > Yeah looks like a good cleanup that also makes downclocking more likely. > > Reviewed-by: Jesse Barnes Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48