From: David Lamparter <equinox@diac24.net>
To: "Štefan Gula" <steweg@ynet.sk>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"David S. Miller" <davem@davemloft.net>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v2, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP
Date: Mon, 16 Jan 2012 21:29:07 +0100 [thread overview]
Message-ID: <20120116202907.GF1077372@jupiter.n2.diac24.net> (raw)
In-Reply-To: <CAGsizz+x1GVNR9Pz=b7wO0ELx29=FMosfvhQWL5K26EpkwsUCg@mail.gmail.com>
At the risk of repeating myself, Linux GRE support already has
provisions for multipoint tunnels. And unlike your code, those reuse the
existing neighbor table infrastructure, including all of its user
interface and introspection capabilities.
It's actually slightly visible in your patch:
On Mon, Jan 16, 2012 at 08:45:14PM +0100, Štefan Gula wrote:
> +++ linux-3.2.1-my/net/ipv4/ip_gre.c 2012-01-16 20:42:03.000000000 +0100
> @@ -716,7 +942,19 @@ static netdev_tx_t ipgre_tunnel_xmit(str
[...]
> /* NBMA tunnel */
>
> if (skb_dst(skb) == NULL) {
-David
next prev parent reply other threads:[~2012-01-16 20:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 19:45 [patch v2, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP Štefan Gula
2012-01-16 20:28 ` Eric Dumazet
2012-01-16 23:11 ` Štefan Gula
2012-01-17 4:47 ` Eric Dumazet
2012-01-17 8:04 ` Štefan Gula
2012-01-17 8:29 ` Eric Dumazet
2012-01-17 10:43 ` Štefan Gula
2012-01-17 10:47 ` Eric Dumazet
2012-01-17 11:00 ` Štefan Gula
2012-01-17 11:00 ` Štefan Gula
2012-01-17 11:15 ` Eric Dumazet
2012-01-17 12:40 ` Štefan Gula
2012-01-16 20:29 ` David Lamparter [this message]
2012-01-16 22:52 ` Štefan Gula
2012-01-17 9:50 ` David Lamparter
2012-01-17 9:56 ` Štefan Gula
2012-01-17 10:11 ` David Lamparter
2012-01-17 10:40 ` Štefan Gula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116202907.GF1077372@jupiter.n2.diac24.net \
--to=equinox@diac24.net \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steweg@ynet.sk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.