From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Check that plane/pipe is disabled
 before removing the fb
Date: Tue, 17 Jan 2012 11:09:21 +0100
Message-ID: <20120117100921.GA4093@phenom.ffwll.local>
References: <20120116224806.GT3627@phenom.ffwll.local>
	<1326754873-2021-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id CEB319E75E
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 02:09:29 -0800 (PST)
Received: by wibhq15 with SMTP id hq15so3403409wib.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 02:09:29 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1326754873-2021-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jan 16, 2012 at 11:01:13PM +0000, Chris Wilson wrote:
> Staring at an error state such as:
> 
> PGTBL_ER: 0x00000400
>     Display B: Invalid tiling
> fence[0] = 05001001
>     valid, x-tiled, pitch: 512, start: 0x05000000, size: 1048576
> Pinned [2]:
>   00000000   131072 0001 0001 00000000 P uncached
>   00020000  4096000 0041 0000 00000000 P uncached (name: 1)
> Plane [1]:
>   CNTR: c0000000 # enabled | gamma
>   STRIDE: 00001400
>   SIZE: 03ff04ff
>   POS: 00000000
>   ADDR: 05000000
> 
> Suggests that we did not clear the DSPBCNTR prior to unpinning the
> framebuffer and reusing the GTT space. Impossible! Unless our DPMS
> bookkeeping ran afoul again...
> 
> In the meantime add an assertion that the plane is decoupled from the
> framebuffer prior to release.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48