From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for
 DisplayPort
Date: Tue, 17 Jan 2012 11:22:03 +0100
Message-ID: <20120117102203.GC4093@phenom.ffwll.local>
References: <20120109131717.GA4713@localhost>
 <86y5tgx02g.fsf@sumi.keithp.com>
 <20120110054519.GA27257@localhost>
 <86ty404yhd.fsf@sumi.keithp.com>
 <20120116080252.GA18538@localhost>
 <20120116202618.GG3627@phenom.ffwll.local>
 <86obu31io4.fsf@sumi.keithp.com>
 <20120116230809.GA7837@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20120116230809.GA7837@localhost>
Sender: linux-kernel-owner@vger.kernel.org
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Keith Packard <keithp@keithp.com>, Daniel Vetter <daniel@ffwll.ch>, Takashi Iwai <tiwai@suse.de>, "intel-gfx@lists.freedesktop..." <intel-gfx@lists.freedesktop.org>, Michal Marek <mmarek@suse.com>, LKML <linux-kernel@vger.kernel.org>, Robert Lemaire <rlemaire@suse.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jan 17, 2012 at 07:08:09AM +0800, Wu Fengguang wrote:
> On Mon, Jan 16, 2012 at 12:44:43PM -0800, Keith Packard wrote:
> > On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> > 
> > > Keith, does this address your concern and this patch is r-b: Keith or do
> > > we want an
> > > 
> > > } else {
> > > 	I915_WRITE(aud_config, 0);
> > > }
> > > 
> > > for paranoia?
> > 
> > I think we want this added, just to be sure we set the configuration
> > correctly in all cases; it's easy to imagine moving from DP to HDMI and
> > leaving this bit set.
> 
> Ah good point! Here is the updated patch.
> 
> ---
> Subject: drm/i915: set AUD_CONFIG N_value_index for DisplayPort
> Date: Fri Jan 06 14:41:31 CST 2012
> 
> It should be programmed to "0" for HDMI or "1" for DisplayPort.
> 
> This enables DisplayPort audio for
> 
> - HP EliteBook 8460p
>   (whose BIOS does not set the N_value_index bit for us)
> 
> - DisplayPort monitor hot plugged after boot
>   (otherwise most BIOS will fill the N_value_index bit for us)
> 
> Tested-by: Robert Lemaire <rlemaire@suse.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

I've tried to apply this patch but it has a conflict in i915_reg.h (with
the SOL reset stuff). Care to rebase and resend? Also, git patches as
produced by git format-patch highly preferred.

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48