From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] ASoC: Allow drivers to specify how many bits are significant on a DAI
Date: Tue, 17 Jan 2012 11:38:49 +0000 [thread overview]
Message-ID: <20120117113848.GE2944@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F15377B.6080108@ti.com>
On Tue, Jan 17, 2012 at 09:55:23AM +0100, Peter Ujfalusi wrote:
Peter, I shouldn't need to have to remind you to delete unneeded context
from your replies.
> Should we apply the constraint only if the sample size is bigger than
> the msbit request:
> if (sample_sizes[i] > bits) {
> ret = snd_pcm_hw_constraint_msbits();
> }
> Might be not an issue to say that we have 24msbit on the 8bit sample,
> but it does not sound right.
It shouldn't hurt and it is potentially useful to the application to
know that things will be converted up by the hardware; unless there's a
great reason to do so I'd rather not hide the information.
next prev parent reply other threads:[~2012-01-17 11:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 18:41 [PATCH 1/2] ASoC: Allow drivers to specify how many bits are significant on a DAI Mark Brown
2012-01-16 18:41 ` [PATCH 2/2] ASoC: 24 bits are significant on the WM8996 audio interfaces Mark Brown
2012-01-16 22:26 ` [PATCH 1/2] ASoC: Allow drivers to specify how many bits are significant on a DAI Girdwood, Liam
2012-01-16 22:42 ` Mark Brown
2012-01-17 8:56 ` Peter Ujfalusi
2012-01-17 8:55 ` Peter Ujfalusi
2012-01-17 11:38 ` Mark Brown [this message]
2012-01-17 13:06 ` Peter Ujfalusi
2012-01-17 13:19 ` Mark Brown
2012-01-17 14:18 ` Peter Ujfalusi
2012-01-17 14:56 ` Mark Brown
2012-01-17 16:08 ` Peter Ujfalusi
2012-01-17 16:44 ` Mark Brown
2012-01-17 17:55 ` Peter Ujfalusi
2012-01-17 18:17 ` Mark Brown
2012-01-17 18:51 ` Peter Ujfalusi
2012-01-17 18:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117113848.GE2944@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.