From: Thomas Renninger <trenn@suse.de>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, len.brown@intel.com, linux-acpi@vger.kernel.org,
shaohua.li@intel.com
Subject: Re: [patch 2/3] intel_idle: disable auto_demotion for hotplugged CPUs
Date: Tue, 17 Jan 2012 11:56:38 +0100 [thread overview]
Message-ID: <201201171156.38490.trenn@suse.de> (raw)
In-Reply-To: <20120110234820.B14B8100270@wpzn3.hot.corp.google.com>
On Wednesday, January 11, 2012 12:48:20 AM akpm@linux-foundation.org wrote:
> From: Shaohua Li <shaohua.li@intel.com>
> Subject: intel_idle: disable auto_demotion for hotplugged CPUs
This one should not be necessary anymore with my intel_idle
patch series I have to rebase and resend (will do that after lunch).
It provides a per cpu intel_idle init function which is called
from processor.ko in physical cpu hotplug case.
>From what I can see this patch does not change anything/much, because:
- CPUs onlined at bootup are initialized correctly already
- Soft offlining/onlining shouldn't matter in auto_demotion_disable
case as it's a HW MSR write and the CPU should still be in the
same state after off- and onlined again.
- Physically hotplugged/added CPUs are not registered with cpuidle
at all (this is what my patch series fixes), because intel_idle
does not offer any per cpu init() entry function.
With this patch they might be set into auto_demotion_disable now,
but no idle driver gets active for them.
I'll pick up patch 1/3 and 3/3, base my patches on top and resend
everything, that should be easiest for everybody?
Thomas
next prev parent reply other threads:[~2012-01-17 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:48 [patch 2/3] intel_idle: disable auto_demotion for hotplugged CPUs akpm
2012-01-17 10:56 ` Thomas Renninger [this message]
2012-01-17 19:22 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201171156.38490.trenn@suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.