All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] omap3 towards thumb2 support
Date: Tue, 17 Jan 2012 14:10:55 +0100	[thread overview]
Message-ID: <20120117131055.GA5446@pengutronix.de> (raw)
In-Reply-To: <E28AAFD00EFAA646AE3DF9B89CD24A89317FD026@DBDE01.ent.ti.com>

On Tue, Jan 17, 2012 at 12:24:26PM +0000, Premi, Sanjeev wrote:
> > -----Original Message-----
> > From: Sascha Hauer [mailto:s.hauer@pengutronix.de] 
> > Sent: Tuesday, January 17, 2012 5:43 PM
> > To: Premi, Sanjeev
> > Cc: barebox@lists.infradead.org
> > Subject: Re: [PATCH] omap3 towards thumb2 support
> > 
> > On Tue, Jan 17, 2012 at 11:14:31AM +0000, Premi, Sanjeev wrote:
> 
> [snip]
> 
> > > > 
> > > > I attached my binary MLO file. Could you check if it 
> > works for you? I
> > > > just checked this binary and it comes up with:
> > > > 
> > > > [sp] I will try tomorrow morning.
> > > 
> > > Sascha,
> > >   Your MLO boots fine. But I couldn't make repeat success on either
> > >   beagle or the omap3evem on my side.
> > > 
> > >   Each time there is an exception on entry of setup_auxcr() on both
> > >   boards. See attached image.
> > > 
> > >   I noticed that the size of the generated MLO for beagle 
> > were different
> > >   for us - 35224(yours) vs. 35572(mine).
> > > 
> > >   I am building with CodeSourcery 2011.03-41.
> > 
> > Ok, got it. Please replace the setup_auxcr patch with the 
> > following one
> > (I also updated the work/omap3 branch). The problem was the missing
> > ENDPROC(setup_auxcr) directive which tells the assembler that
> > setup_auxcr is a function. With this the function is correctly called
> > with 'blx' instead of 'bl'. 'blx' is needed because setup_auxcr is
> > compiled in arm mode instead of thumb2 mode. Somehow my toolchain
> > got that right without ENDPROC but the codesourcery toolchain didn't.
> > With this patch the binary also works with the codesourcery toolchain.
> > 
> 
> I replaced the contents of auxcr.S and I am able to boot fine on the
> OMAP3EVM.
> 
> BTW, I noticed that this file has no license header. Is this okay?

Added one. Can I have your tested-by?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-01-17 13:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 10:18 [PATCH] omap3 towards thumb2 support Sascha Hauer
2012-01-16 10:18 ` [PATCH 01/10] ARM omap3: remove OMAP3_COPY_CLOCK_SRAM Sascha Hauer
2012-01-16 10:18 ` [PATCH 02/10] ARM omap3 beagle xload: Move stack to SRAM Sascha Hauer
2012-01-16 10:18 ` [PATCH 03/10] ARM omap3: move board_init to pure_initcall Sascha Hauer
2012-01-16 10:18 ` [PATCH 04/10] ARM omap3: call a_init from board code Sascha Hauer
2012-01-16 10:18 ` [PATCH 05/10] ARM omap3 clock: move pll tables to C code Sascha Hauer
2012-01-16 10:18 ` [PATCH 06/10] ARM omap3: remove vector setup from lowlevel code Sascha Hauer
2012-01-16 10:18 ` [PATCH 07/10] ARM omap3: reimplement setup_auxcr in pure asm Sascha Hauer
2012-01-16 10:18 ` [PATCH 08/10] ARM cache-armv7: Add additional ISB Sascha Hauer
2012-01-16 10:18 ` [PATCH 09/10] mtd omap nand: fix driver without CONFIG_PARAMETER Sascha Hauer
2012-01-16 10:34   ` Sascha Hauer
2012-01-16 10:18 ` [PATCH 10/10] ARM omap3: make omap3_core.S thumb safe Sascha Hauer
2012-01-16 11:30 ` [PATCH] omap3 towards thumb2 support Premi, Sanjeev
2012-01-16 11:52   ` Sascha Hauer
2012-01-16 12:01     ` Premi, Sanjeev
2012-01-16 12:42       ` Premi, Sanjeev
2012-01-16 15:46         ` Sascha Hauer
2012-01-16 16:16           ` Premi, Sanjeev
2012-01-17 11:14             ` Premi, Sanjeev
2012-01-17 12:12               ` Sascha Hauer
2012-01-17 12:24                 ` Premi, Sanjeev
2012-01-17 13:10                   ` Sascha Hauer [this message]
2012-01-17 13:20                     ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120117131055.GA5446@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.