All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h
Date: Tue, 17 Jan 2012 15:08:05 +0100	[thread overview]
Message-ID: <201201171508.05802.trenn@suse.de> (raw)
In-Reply-To: <4F155A94.3070403@kernel.org>

On Tuesday, January 17, 2012 12:25:08 PM Len Brown wrote:
> On 11/17/2011 05:36 PM, Thomas Renninger wrote:
> 
> > Instead move its declaration from processor_idle.c to processor_driver.c
> > and declare it static as it's the only file using this struct.
> > 
> > Cleanup only, no functional change.
> > 
> > Signed-off-by: Thomas Renninger <trenn@suse.de>
> > CC: Len Brown <lenb@kernel.org>
> > CC: linux-acpi@vger.kernel.org
> > ---
> >  drivers/acpi/processor_driver.c |    5 +++++
> >  drivers/acpi/processor_idle.c   |    5 -----
> >  include/acpi/processor.h        |    1 -
> >  3 files changed, 5 insertions(+), 6 deletions(-)
> > 
> 
> 
> drivers/acpi/processor_idle.c: In function ‘acpi_processor_setup_cpuidle_states’:
> drivers/acpi/processor_idle.c:1032:32: error: ‘acpi_idle_driver’ undeclared (first use in this function)
> drivers/acpi/processor_idle.c:1032:32: note: each undeclared identifier is reported only once for each function it appears in
> drivers/acpi/processor_idle.c: In function ‘acpi_processor_cst_has_changed’:
> drivers/acpi/processor_idle.c:1158:29: error: ‘acpi_idle_driver’ undeclared (first use in this function)
> drivers/acpi/processor_idle.c: In function ‘acpi_processor_power_init’:
> drivers/acpi/processor_idle.c:1239:38: error: ‘acpi_idle_driver’ undeclared (first use in this function)
> drivers/acpi/processor_idle.c: In function ‘acpi_processor_power_exit’:
> drivers/acpi/processor_idle.c:1270:31: error: ‘acpi_idle_driver’ undeclared (first use in this function)
> 
> eh?
Oh, this one does not work anymore since:
commit 46bcfad7a819bd17ac4e831b04405152d59784ab
Author: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Date:   Fri Oct 28 16:20:42 2011 +0530

    cpuidle: Single/Global registration of idle states

got merged in recently.
Please ignore this patch.

   Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-01-17 14:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1321569421-46220-1-git-send-email-trenn@suse.de>
2011-11-17 22:36 ` [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h Thomas Renninger
2012-01-17 11:25   ` Len Brown
2012-01-17 14:08     ` Thomas Renninger [this message]
2011-11-17 22:36 ` [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal Thomas Renninger
2012-01-17 11:02   ` Len Brown
2012-01-17 14:25     ` Thomas Renninger
2012-01-17 14:41       ` Bjorn Helgaas
2012-01-17 14:58     ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 3/5] intel_idle: Split up and provide per CPU initialization func Thomas Renninger
2011-11-17 22:44   ` Thomas Renninger
2012-01-17 11:06   ` Len Brown
2012-01-17 13:26     ` Thomas Renninger
2012-01-17 16:10       ` Thomas Renninger
2011-11-17 22:37 ` [PATCH 4/5] ACPI processor: Fix error path, also remove sysdev link Thomas Renninger
2011-11-17 22:37 ` [PATCH 5/5] ACPI processor: Remove unneeded variable passed by acpi_processor_hotadd_init Thomas Renninger
2012-01-17 11:10   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201171508.05802.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.