From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Tony Luck <tony.luck@intel.com>,
Marco Stornelli <marco.stornelli@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <greg@kroah.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ramoops: use pstore interface
Date: Tue, 17 Jan 2012 15:55:52 -0800 [thread overview]
Message-ID: <20120117155552.be287c61.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jJ_RWNKC7QgGXYgLFv6QCmkjw4z11WVcB=8BFacye0a3Q@mail.gmail.com>
On Tue, 17 Jan 2012 15:48:25 -0800
Kees Cook <keescook@chromium.org> wrote:
> > Note that pstore_get_records() will treat the -ve errno returns from
> > ->read() in the same manner as EOF. IOW, your error codes will be
> > dropped on the floor. This appears to be a bug in pstore_get_records().
>
> Well, IIUC, it just means the file doesn't get populated at all; there
> is no userspace interface to finding out why a file didn't appear in
> the pstore fliesystem. But yes, the specifics of the error are ignored
> by pstore_get_records(). It didn't seem wrong to produce meaningful
> codes in ramoops, though.
>
Well, there's a printk() in there. But it only comes out if it was
pstore_mkfile() which failed.
prev parent reply other threads:[~2012-01-17 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 17:15 [PATCH v4] ramoops: use pstore interface Kees Cook
2012-01-17 21:59 ` Andrew Morton
2012-01-17 23:48 ` Kees Cook
2012-01-17 23:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117155552.be287c61.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.