From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/1] drm/i915: print out which pixel format
 we do not support
Date: Tue, 17 Jan 2012 18:23:00 +0100
Message-ID: <20120117172300.GS4093@phenom.ffwll.local>
References: <1326820271-29502-1-git-send-email-eugeni.dodonov@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 594C7A01D4
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 09:23:04 -0800 (PST)
Received: by wibhq15 with SMTP id hq15so3836803wib.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Jan 2012 09:23:03 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1326820271-29502-1-git-send-email-eugeni.dodonov@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jan 17, 2012 at 03:11:11PM -0200, Eugeni Dodonov wrote:
> Otherwise, we are left with pretty bogus message saying that the pixel
> format is not supported while leaving the details to the telepatic powers.
> 
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ebe71ed..5d47d0d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,
>  	case DRM_FORMAT_VYUY:
>  		break;
>  	default:
> -		DRM_ERROR("unsupported pixel format\n");
> +		DRM_ERROR("unsupported pixel format %u\n",
> +				mode_cmd->pixel_format);

While we're bashing Jesse, this looks like a user-triggerable error. Can
we have a DRM_DEBUG_KMS instead?
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48