From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann To: Maxime Ripard Subject: Re: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver. Date: Tue, 17 Jan 2012 17:35:05 +0000 Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Jean-Christophe PLAGNIOL-VILLARD" , Nicolas Ferre , Patrice Vilchez , Thomas Petazzoni , Jonathan Cameron , Marek Vasut References: <1326749786-13035-1-git-send-email-maxime.ripard@free-electrons.com> <1326749786-13035-3-git-send-email-maxime.ripard@free-electrons.com> In-Reply-To: <1326749786-13035-3-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Message-Id: <201201171735.06166.arnd@arndb.de> List-ID: On Monday 16 January 2012, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard > > Cc: Jean-Christophe PLAGNIOL-VILLARD > Cc: Nicolas Ferre > Cc: Patrice Vilchez > Cc: Thomas Petazzoni > Cc: Jonathan Cameron > Cc: Marek Vasut > Cc: Arnd Bergmann I think I reviewed this driver before, but I don't remember any of the details I may have complained about. I assume everything was fixed, since the driver looks good in this version ;-) Acked-by: Arnd Bergmann Two general comments: * Please add a changeset description (i.e. thetext above your Signed-off-by: line) for every patch you do. Just read a few dozen patches that get posted to lkml to get a feeling for what would be useful to have in there. For a new driver, it would be helpful to know what hardware uses this driver and what the device does there. * Over time, we will get stricter in requiring device tree bindings for new platform devices, to replace platform_data where appropriate. It's not required yet, but it would be nice to describe the long-term plan in submissions that add new platform_data but no device tree bindings. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 17 Jan 2012 17:35:05 +0000 Subject: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver. In-Reply-To: <1326749786-13035-3-git-send-email-maxime.ripard@free-electrons.com> References: <1326749786-13035-1-git-send-email-maxime.ripard@free-electrons.com> <1326749786-13035-3-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <201201171735.06166.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 16 January 2012, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard > > Cc: Jean-Christophe PLAGNIOL-VILLARD > Cc: Nicolas Ferre > Cc: Patrice Vilchez > Cc: Thomas Petazzoni > Cc: Jonathan Cameron > Cc: Marek Vasut > Cc: Arnd Bergmann I think I reviewed this driver before, but I don't remember any of the details I may have complained about. I assume everything was fixed, since the driver looks good in this version ;-) Acked-by: Arnd Bergmann Two general comments: * Please add a changeset description (i.e. thetext above your Signed-off-by: line) for every patch you do. Just read a few dozen patches that get posted to lkml to get a feeling for what would be useful to have in there. For a new driver, it would be helpful to know what hardware uses this driver and what the device does there. * Over time, we will get stricter in requiring device tree bindings for new platform devices, to replace platform_data where appropriate. It's not required yet, but it would be nice to describe the long-term plan in submissions that add new platform_data but no device tree bindings. Arnd