All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: JONGMAN HEO <jongman.heo@samsung.com>
Cc: linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: build failure with current linus tree
Date: Wed, 18 Jan 2012 01:51:22 +0000	[thread overview]
Message-ID: <20120118015122.GW23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <27516709.76321326849450926.JavaMail.weblogic@epml05>

On Wed, Jan 18, 2012 at 01:17:31AM +0000, JONGMAN HEO wrote:
> 
> With current linus git (commit a25a2b84), I got following build error,
> 
> arch/x86/kernel/vm86_32.c: In function ??do_sys_vm86??:
> arch/x86/kernel/vm86_32.c:340: error: implicit declaration of function ??__audit_syscall_exit??
> make[3]: *** [arch/x86/kernel/vm86_32.o] Error 1
> 
> I do not have CONFIG_AUDITSYSCALL in my .config.

Um...  OK, I can reproduce it (32bit allmodconfig with AUDIT=y, AUDITSYSCALL=n)
Crap...  It's "Audit: push audit success and retcode into arch ptrace.h".

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
index af17e1c..b466cab 100644
--- a/arch/x86/kernel/vm86_32.c
+++ b/arch/x86/kernel/vm86_32.c
@@ -336,8 +336,10 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
 		mark_screen_rdonly(tsk->mm);
 
 	/*call __audit_syscall_exit since we do not exit via the normal paths */
+#ifdef CONFIG_AUDITSYSCALL
 	if (unlikely(current->audit_context))
 		__audit_syscall_exit(1, 0);
+#endif
 
 	__asm__ __volatile__(
 		"movl %0,%%esp\n\t"

  reply	other threads:[~2012-01-18  1:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  1:17 build failure with current linus tree JONGMAN HEO
2012-01-18  1:51 ` Al Viro [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-05  1:06 Christoph Hellwig
2008-09-09 23:56 ` Christoph Hellwig
2008-09-17 18:04   ` Chris Friesen
2008-09-17 18:44     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118015122.GW23916@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=eparis@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jongman.heo@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.