diff for duplicates of <20120118130550.0bdb227e.akpm@linux-foundation.org> diff --git a/a/1.txt b/N1/1.txt index 59bcb41..ba9c541 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -91,7 +91,7 @@ Strange code layout. > + if (!lcd_dev) > + continue; > + -> + if ((strcmp(lcd_drv->name, lcd_dev->name)) = 0) { +> + if ((strcmp(lcd_drv->name, lcd_dev->name)) == 0) { hm, using strcmp() to compare devices in this way looks fishy. But I don't know what is going on here. @@ -173,7 +173,7 @@ More code layout oddness. > + dev_dbg(dsim->dev, "lcd_dev->bus_id = %d, dsim->id = %d\n", > + lcd_dev->bus_id, dsim->id); > + -> + if ((strcmp(lcd_drv->name, name) = 0)) { +> + if ((strcmp(lcd_drv->name, name) == 0)) { > + lcd_dev->master = dsim; > + > + lcd_dev->dev.parent = dsim->dev; @@ -229,7 +229,7 @@ ENOMEM! > + > + /* get mipi_dsim_platform_data. */ > + dsim_pd = (struct mipi_dsim_platform_data *)dsim->pd; -> + if (dsim_pd = NULL) { +> + if (dsim_pd == NULL) { > + dev_err(&pdev->dev, "failed to get platform data for dsim.\n"); > + goto err_clock_get; > + } diff --git a/a/content_digest b/N1/content_digest index 06ebb75..1ddd25e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\04F16288C.5020406@samsung.com\0" - "From\0Andrew Morton <akpm@linux-foundation.org>\0" - "Subject\0Re: [PATCH v6 1/2] video: support MIPI-DSI controller driver\0" - "Date\0Wed, 18 Jan 2012 21:05:50 +0000\0" + "From\0akpm@linux-foundation.org (Andrew Morton)\0" + "Subject\0[PATCH v6 1/2] video: support MIPI-DSI controller driver\0" + "Date\0Wed, 18 Jan 2012 13:05:50 -0800\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -98,7 +98,7 @@ "> +\t\tif (!lcd_dev)\n" "> +\t\t\tcontinue;\n" "> +\n" - "> +\t\tif ((strcmp(lcd_drv->name, lcd_dev->name)) = 0) {\n" + "> +\t\tif ((strcmp(lcd_drv->name, lcd_dev->name)) == 0) {\n" "\n" "hm, using strcmp() to compare devices in this way looks fishy. But I\n" "don't know what is going on here.\n" @@ -180,7 +180,7 @@ "> +\t\tdev_dbg(dsim->dev, \"lcd_dev->bus_id = %d, dsim->id = %d\\n\",\n" "> +\t\t\t\tlcd_dev->bus_id, dsim->id);\n" "> +\n" - "> +\t\tif ((strcmp(lcd_drv->name, name) = 0)) {\n" + "> +\t\tif ((strcmp(lcd_drv->name, name) == 0)) {\n" "> +\t\t\tlcd_dev->master = dsim;\n" "> +\n" "> +\t\t\tlcd_dev->dev.parent = dsim->dev;\n" @@ -236,7 +236,7 @@ "> +\n" "> +\t/* get mipi_dsim_platform_data. */\n" "> +\tdsim_pd = (struct mipi_dsim_platform_data *)dsim->pd;\n" - "> +\tif (dsim_pd = NULL) {\n" + "> +\tif (dsim_pd == NULL) {\n" "> +\t\tdev_err(&pdev->dev, \"failed to get platform data for dsim.\\n\");\n" "> +\t\tgoto err_clock_get;\n" "> +\t}\n" @@ -288,4 +288,4 @@ "Generally: the use of the Efoo errno codes is chaotic. Please check it\n" all over. -e1dbc6740544b7f78236aacf0fdcfb6a2d28b316ae2b4385d121667f3a753878 +530fb1cc551077c1701862c74f925acc89f045fb1b05281b43580008ade1b855
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.