Re: [PATCH] libxl_pci: check that host device is assignable before adding to the domain

[Konrad Rzeszutek Wilk <konrad@darnok.org>]

On Tue, Jan 17, 2012 at 05:02:08PM -0500, djmagee@mageenet.net wrote:
> > -----Original Message-----
> > From: Konrad Rzeszutek Wilk [mailto:konrad@darnok.org]
> > Sent: Tuesday, January 17, 2012 3:13 PM
> > To: djmagee@mageenet.net
> > Cc: Ian Campbell; xen-devel@lists.xensource.com; Ian Jackson; Stefano
> > Stabellini
> > Subject: Re: [Xen-devel] [PATCH] libxl_pci: check that host device is
> > assignable before adding to the domain
> > 
> > On Tue, Jan 17, 2012 at 09:24:39AM -0500, djmagee@mageenet.net wrote:
> > > > -----Original Message-----
> > > > From: Ian Campbell [mailto:Ian.Campbell@citrix.com]
> > > > Sent: Tuesday, January 17, 2012 9:16 AM
> > > > To: djmagee@mageenet.net
> > > > Cc: xen-devel@lists.xensource.com; Ian Jackson; Stefano Stabellini
> > > > Subject: RE: [Xen-devel] [PATCH] libxl_pci: check that host device
> > is
> > > > assignable before adding to the domain
> > > >
> > > > Please don't top post.
> > > >
> > > > On Tue, 2012-01-17 at 14:05 +0000, djmagee@mageenet.net wrote:
> > > > > That was my first thought, but this was also the first thing in
> > libxl
> > > > > I touched and wasn't sure what would happen if I ended up
> nesting
> > > > > GC_INITs.  If it's safe to do then I can call
> > > > > libxl_device_pci_list_assignable, otherwise I'd have to pull the
> > meat
> > > > > out and put it in another function.  What's the best way to do
> > it?
> > > >
> > > > You can use libxl__gc_owner(gc) (or the helpful CTX macro) to get
> a
> > ctx
> > > > from a gc which you use to call an externally visible function
> from
> > > > within libxl -- it'll do the right thing (TM).
> > >
> > > Cool, I'll send an updated patch along today.
> > 
> > You might want to check for 'xen-pciback', 'pciback' and 'pci-stub'
> > as they are valid.
> 
> Agreed. I posted an updated patch that calls ..._list_assignable instead
> of looping through the directory itself.  I'll work on a separate patch
> to update that function to check all applicable places.
> 
> In the 3.2.1 kernel I'm using, the module name is xen-pcipack, but the
> sysfs directory is just pciback.  Is there an instance where the
> directory is called xen-pcipack?

Not yet. I was hoping that somebody would create a patch in the
toolstack for it so that I can rename it to 'xen-pciback'.

So more of the 'this will happen in Q2 2012'