From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365Ab2ARRdz (ORCPT ); Wed, 18 Jan 2012 12:33:55 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:52713 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932326Ab2ARRdx (ORCPT ); Wed, 18 Jan 2012 12:33:53 -0500 Date: Wed, 18 Jan 2012 09:33:48 -0800 From: Tejun Heo To: "Srivatsa S. Bhat" Cc: "Rafael J. Wysocki" , Linux PM list , LKML , horms@verge.net.au, "pavel@ucw.cz" , Len Brown Subject: Re: [Update][PATCH] PM / Hibernate: Fix s2disk regression related to unlock_system_sleep() Message-ID: <20120118173348.GF30664@google.com> References: <201201172345.15010.rjw@sisk.pl> <201201180015.56510.rjw@sisk.pl> <4F16C24A.4050007@linux.vnet.ibm.com> <4F16F94C.4020000@linux.vnet.ibm.com> <4F16FF0D.1030606@linux.vnet.ibm.com> <20120118173037.GE30664@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120118173037.GE30664@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2012 at 09:30:37AM -0800, Tejun Heo wrote: > Hello, Srivatsa. > > On Wed, Jan 18, 2012 at 10:49:09PM +0530, Srivatsa S. Bhat wrote: > > I agree, but I was trying to keep the comment from growing too long ;) > > It doesn't have to be long. It just has to give some meaning to the > decision. AFAICS, it is correct to call try_to_freeze() on > unlock_system_sleep() regardless of 20sec window. There's no > guarantee the unlocking task is gonna hit try_to_freeze() elsewhere > and not calling it actually makes the interface buggy. To give an example, /* * XXX: Open code SKIP clearing for now to avoid invoking * try_to_freeze(). This isn't correct but this function is * called from deep inside hibernation path and calling * try_to_freeze() leads to hang during hibernation. This * will be properly fixed soon. See commit message for * more details. */ Thanks. -- tejun