All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Oester <kernel@linuxace.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: bpf_jit: fix divide by 0 generation
Date: Wed, 18 Jan 2012 09:48:07 -0800	[thread overview]
Message-ID: <20120118174807.GA5159@linuxace.com> (raw)
In-Reply-To: <1326907302.4910.11.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>

On Wed, Jan 18, 2012 at 06:21:42PM +0100, Eric Dumazet wrote:
> Several problems fixed in this patch :
> 
> 1) Target of the conditional jump in case a divide by 0 is performed
>    by a bpf is wrong.
> 
> 2) Must 'generate' the full function prologue/epilogue at pass=0,
>    or else we can stop too early in pass=1 if the proglen doesnt change.
>    (if the increase of prologue/epilogue equals decrease of all
>     instructions length because some jumps are converted to near jumps)
> 
> 3) Change the wrong length detection at the end of code generation to
>    issue a more explicit message, no need for a full stack trace.
> 
> Reported-by: Phil Oester <kernel@linuxace.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> Please Phil test following fix, thanks !

Looks good in testing so far, thank you!

Phil

  reply	other threads:[~2012-01-18 17:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18  2:27 bpf_jit_compile issues on x86_64 Phil Oester
2012-01-18  6:17 ` Eric Dumazet
2012-01-18  7:30   ` Eric Dumazet
2012-01-18  7:58     ` [PATCH] net: bpf_jit: fix divide by 0 generation Eric Dumazet
2012-01-18 15:57       ` Phil Oester
2012-01-18 16:01         ` Eric Dumazet
2012-01-18 17:21           ` [PATCH v2] " Eric Dumazet
2012-01-18 17:48             ` Phil Oester [this message]
2012-01-18 21:04             ` David Miller
2012-01-19  8:07           ` [PATCH] " Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118174807.GA5159@linuxace.com \
    --to=kernel@linuxace.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.