From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pradheep Shrinivasan <pradheep.sh@gmail.com>,
Andy Whitcroft <apw@canonical.com>
Cc: greg@kroah.com, devel@linuxdriverproject.org,
swetland@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl
Date: Wed, 18 Jan 2012 21:54:57 +0300 [thread overview]
Message-ID: <20120118185457.GH3356@mwanda> (raw)
In-Reply-To: <CANz8tm1imZ3njy_uV0tkq0sXwyB5ZLLJsrp4G1zjcBDnJUrjiw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Wed, Jan 18, 2012 at 11:38:34PM +0530, Pradheep Shrinivasan wrote:
>> > > -#define PMEM_IOCTL_MAGIC 'p'
> > > +#define PMEM_IOCTL_MAGIC ('p')
> >
> > You don't need parenthesis here. Did checkpatch really complain
> > about this?
>
> Yes the check patch does complain about the parenthesis.
>
> pradheep@ubuntu:~/linux-next/
> linux-next/drivers/staging/android$ checkpatch android_pmem.h
> android_pmem.h:10: ERROR: trailing whitespace
> android_pmem.h:19: ERROR: Macros with complex values should be enclosed in
> parenthesis
That seems like a bug in checkpatch.pl. It's hard to imagine less
complex macro than: #define PMEM_IOCTL_MAGIC 'p'
Perhaps if the check looked for one of these characters: */+-=<>|&
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next parent reply other threads:[~2012-01-18 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1326856764-2531-1-git-send-email-pradheep.sh@gmail.com>
[not found] ` <20120118065620.GE3294@mwanda>
[not found] ` <CANz8tm1imZ3njy_uV0tkq0sXwyB5ZLLJsrp4G1zjcBDnJUrjiw@mail.gmail.com>
2012-01-18 18:54 ` Dan Carpenter [this message]
2012-01-20 11:12 ` [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl Andy Whitcroft
2012-01-20 11:54 ` Dan Carpenter
2012-01-20 12:18 ` Andy Whitcroft
2012-01-20 13:29 ` Joe Perches
2012-01-20 13:50 ` Dan Carpenter
2012-01-20 16:28 ` Andy Whitcroft
2012-01-20 13:15 ` Joe Perches
2012-01-20 13:46 ` Dan Carpenter
2012-01-20 17:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118185457.GH3356@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pradheep.sh@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.