From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Swapna Thete
<swapna.thete-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jack Morgenstein <jackm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 2/2] IB/mad: Return unsupported for MADs as appropriate
Date: Wed, 18 Jan 2012 11:56:20 -0700 [thread overview]
Message-ID: <20120118185620.GJ2892@obsidianresearch.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A823732DC00DEE-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Wed, Jan 18, 2012 at 05:20:13PM +0000, Hefty, Sean wrote:
> > Surely we should be picking the response status based on the IB spec
> > rather than on the error message that some arbitrary tool prints?
>
> agreed - these are the basic choices:
>
> Code for invalid field
> 0 - no invalid fields
> 1 - Bad version. Either the base version, or the class version, or the
> combination of the two is not supported.
> 2 - The method specified is not supported
> 3 - The method/attribute combination is not supported
>
> none of which seem that great... IMO, unsupported class version
> seems as good as any.
Figure 169 specifies the validation flow. 1 is the correct reply for
'Management class is not supported on this port'.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-18 18:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 8:42 [PATCH 0/2] Setup response for MADs as appropriate Swapna Thete
[not found] ` <20120118084255.18560.40844.stgit-hIFRcJ1SNwcXGO8/Qfapyjg/wwJxntczYPYVAmT7z5s@public.gmane.org>
2012-01-18 8:43 ` [PATCH 1/2] IB/mad: Add MAD error codes per IBTA spec Swapna Thete
2012-01-18 8:43 ` [PATCH 2/2] IB/mad: Return unsupported for MADs as appropriate Swapna Thete
[not found] ` <20120118084311.18560.22509.stgit-hIFRcJ1SNwcXGO8/Qfapyjg/wwJxntczYPYVAmT7z5s@public.gmane.org>
2012-01-18 10:04 ` Or Gerlitz
[not found] ` <4F169940.5090007-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-01-18 10:14 ` Swapna Thete
[not found] ` <4C2744E8AD2982428C5BFE523DF8CDCB5CD590F65E-amwN6d8PyQWXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-18 16:52 ` Roland Dreier
[not found] ` <CAL1RGDUh1AEMdok69RJP1cTchvCW7C7HJFTmYm=kUNu7hWA_5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-18 17:20 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732DC00DEE-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-18 18:56 ` Jason Gunthorpe [this message]
[not found] ` <20120118185620.GJ2892-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-19 8:13 ` Jack Morgenstein
2012-01-18 18:06 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732DC03E16-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-18 19:02 ` Jason Gunthorpe
[not found] ` <20120118190214.GK2892-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-18 19:06 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732DC04EDB-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-18 19:50 ` Jason Gunthorpe
2012-01-18 19:30 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732DC04EFB-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-18 21:19 ` Jason Gunthorpe
[not found] ` <20120118211916.GM2892-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-01-19 12:34 ` Swapna Thete
2012-01-19 12:35 ` Swapna Thete
2012-01-18 22:30 ` Hal Rosenstock
[not found] ` <4F1747F2.3020308-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-01-19 12:58 ` Hal Rosenstock
[not found] ` <4F181361.4050505-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-01-20 12:12 ` Swapna Thete
[not found] ` <4C2744E8AD2982428C5BFE523DF8CDCB5CD590F82C-amwN6d8PyQWXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2012-01-20 13:56 ` Hal Rosenstock
2012-01-20 15:27 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732DC0E524-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-20 20:07 ` Hal Rosenstock
2012-01-24 12:32 ` Swapna Thete
-- strict thread matches above, loose matches on Subject: below --
2012-01-31 8:11 [PATCH 0/2] Setup response " Swapna Thete
[not found] ` <20120131081138.9009.33668.stgit-hIFRcJ1SNwcXGO8/Qfapyjg/wwJxntczYPYVAmT7z5s@public.gmane.org>
2012-01-31 8:11 ` [PATCH 2/2] IB/mad: Return unsupported " Swapna Thete
[not found] ` <20120131081153.9009.16378.stgit-hIFRcJ1SNwcXGO8/Qfapyjg/wwJxntczYPYVAmT7z5s@public.gmane.org>
2012-01-31 14:58 ` Hal Rosenstock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118185620.GJ2892@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jackm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swapna.thete-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.