All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: enable MI_WTF bit; I mean MI_FLUSH
Date: Thu, 19 Jan 2012 11:35:22 +0100	[thread overview]
Message-ID: <20120119103522.GC3779@phenom.ffwll.local> (raw)
In-Reply-To: <1326948762-16025-1-git-send-email-ben@bwidawsk.net>

On Wed, Jan 18, 2012 at 08:52:42PM -0800, Ben Widawsky wrote:
> We've seen a few patches now which switch the flush enable bit from bit
> 11 to bit 12 (as the documentation suggests it should be). However this
> turned out to be problematic for us.
> 
> The simulator has shed some light for us. It's not bit 11, and it's not
> bit 12; it's both. Instead of renaming the bits according to the docs
> since we're still really not sure, I've decided to just make the
> MI_FLUSH_ENABLE be both bits. As an aside, the simulator still makes a
> distinction for these two bits, however the error message doesn't seem
> to.
> 
> I don't believe this is actually required for the simulator to be
> function, but it does produce an annoying error message every time
> MI_FLUSH is used without this.
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Because HAS seems to only be able to run ivb fulsim: Have you checked snb
fulsim source for this warning and it's also there? Your changelog is also
silent on how well this works on real hw, can you clarify?

Last but not least, please add a small comment to the #define explaining
what's going on.

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

      parent reply	other threads:[~2012-01-19 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  4:52 [PATCH] drm/i915: enable MI_WTF bit; I mean MI_FLUSH Ben Widawsky
2012-01-19  4:55 ` Ben Widawsky
2012-01-19 10:33   ` Chris Wilson
2012-01-19 10:35 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120119103522.GC3779@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.