From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074! Date: Thu, 19 Jan 2012 16:49:19 +0000 Message-ID: <20120119164919.GE3143@suse.de> References: <1326949826.5016.5.camel@lappy> <20120119122354.66eb9820.kamezawa.hiroyu@jp.fujitsu.com> <20120119130353.0ca97435.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hugh Dickins Cc: KAMEZAWA Hiroyuki , Sasha Levin , hannes , mhocko-AlSwsSmVLrQ@public.gmane.org, bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Dave Jones , Andrew Morton , linux-kernel , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote: > > > > Another question is who pushes pages to LRU before setting pc->mem_cgroup.. > > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware. > > I don't think so: Mel agreed that the patch could not go forward as is, > without an additional pageflag, and asked Andrew to drop it from mmotm > in mail on 29th December (I didn't notice an mm-commits message to say > akpm did drop it, and marc is blacked out in protest for today, so I > cannot check: but certainly akpm left it out of his push to Linus). > > Oh, and Mel noticed another bug in it on the 30th, that the PageLRU > check in the function you quote above is wrong: see PATCH 11/11 thread. > Yes, that patch is broken. According to the mm-commits list, it was "withdrawn" on December 30th. I do not know why it is still in linux-next but AFAIK, it is not expected to end up in mainline. I do not have a fixed version of the patch at the moment. -- Mel Gorman SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 68A376B004F for ; Thu, 19 Jan 2012 11:49:25 -0500 (EST) Date: Thu, 19 Jan 2012 16:49:19 +0000 From: Mel Gorman Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074! Message-ID: <20120119164919.GE3143@suse.de> References: <1326949826.5016.5.camel@lappy> <20120119122354.66eb9820.kamezawa.hiroyu@jp.fujitsu.com> <20120119130353.0ca97435.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: KAMEZAWA Hiroyuki , Sasha Levin , hannes , mhocko@suse.cz, bsingharora@gmail.com, Dave Jones , Andrew Morton , linux-kernel , cgroups@vger.kernel.org, linux-mm@kvack.org On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote: > > > > Another question is who pushes pages to LRU before setting pc->mem_cgroup.. > > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware. > > I don't think so: Mel agreed that the patch could not go forward as is, > without an additional pageflag, and asked Andrew to drop it from mmotm > in mail on 29th December (I didn't notice an mm-commits message to say > akpm did drop it, and marc is blacked out in protest for today, so I > cannot check: but certainly akpm left it out of his push to Linus). > > Oh, and Mel noticed another bug in it on the 30th, that the PageLRU > check in the function you quote above is wrong: see PATCH 11/11 thread. > Yes, that patch is broken. According to the mm-commits list, it was "withdrawn" on December 30th. I do not know why it is still in linux-next but AFAIK, it is not expected to end up in mainline. I do not have a fixed version of the patch at the moment. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756779Ab2ASQt0 (ORCPT ); Thu, 19 Jan 2012 11:49:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47895 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323Ab2ASQtY (ORCPT ); Thu, 19 Jan 2012 11:49:24 -0500 Date: Thu, 19 Jan 2012 16:49:19 +0000 From: Mel Gorman To: Hugh Dickins Cc: KAMEZAWA Hiroyuki , Sasha Levin , hannes , mhocko@suse.cz, bsingharora@gmail.com, Dave Jones , Andrew Morton , linux-kernel , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074! Message-ID: <20120119164919.GE3143@suse.de> References: <1326949826.5016.5.camel@lappy> <20120119122354.66eb9820.kamezawa.hiroyu@jp.fujitsu.com> <20120119130353.0ca97435.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote: > > > > Another question is who pushes pages to LRU before setting pc->mem_cgroup.. > > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware. > > I don't think so: Mel agreed that the patch could not go forward as is, > without an additional pageflag, and asked Andrew to drop it from mmotm > in mail on 29th December (I didn't notice an mm-commits message to say > akpm did drop it, and marc is blacked out in protest for today, so I > cannot check: but certainly akpm left it out of his push to Linus). > > Oh, and Mel noticed another bug in it on the 30th, that the PageLRU > check in the function you quote above is wrong: see PATCH 11/11 thread. > Yes, that patch is broken. According to the mm-commits list, it was "withdrawn" on December 30th. I do not know why it is still in linux-next but AFAIK, it is not expected to end up in mainline. I do not have a fixed version of the patch at the moment. -- Mel Gorman SUSE Labs