Re: [PATCH v6] ASoC: Apply msbits constraint for sample size bigger than the msbits

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Jan 19, 2012 at 05:06:03PM +0100, Peter Ujfalusi wrote:

> Let's try this way.
> I think this implementation is quete clear for the first look to understand what
> it is doing.

>  	for (i = 0; i < ARRAY_SIZE(sample_sizes); i++) {
> +		if (sample_sizes[i] > bits) {
> +			ret = snd_pcm_hw_constraint_msbits(substream->runtime,
> +						      0, sample_sizes[i], bits);
> +			if (ret != 0)
> +				dev_warn(dai->dev,
> +					 "Failed to set MSB %d/%d: %d\n",
> +					 bits, sample_sizes[i], ret);
> +		} else {
> +			/*
> +			 * The remaining sample sizes are smaller than the
> +			 * requested msbits, we can bail out from the loop.
> +			 */
> +			break;
> +		}

*sigh*  I think from the tone of the above you know that's not really
addressing the issue.

My yak is getting pretty bald now and I'm running out of razors.