Re: [PATCH] ASoC: Add external amplifier controls for Visstrim_M10.

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Jan 19, 2012 at 05:37:46PM +0100, javier Martin wrote:
> On 19 January 2012 16:45, Mark Brown

> >> +     ret = mxc_gpio_setup_multiple_pins(mx27vis_amp_pins,
> >> +                     ARRAY_SIZE(mx27vis_amp_pins), "MX27VIS_AMP");
> >> +     if (ret) {
> >> +             printk(KERN_ERR "ASoC: unable to setup gpios\n");
> >> +             platform_device_put(mx27vis_aic32x4_snd_device);
> >> +     }

> > This looks awfully like it should be arch/arm code except it looks like
> > it also munges in the gpio_request.  Odd.

> This is a doubt I had. I could also use board specific file to request
> these gpios and then use some platform data to tell the driver what
> GPIOS must be used.
> However, as those gpios are fixed for all Visstrim_M10 boards I
> considered it didn't worth it.

> On the other hand, if you think it's cleaner that way I can do that.

I think this is just the arch being non-standard.