From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/4] Revert "ASoC: tlv320dac33: Use core to set the msbits constraint"
Date: Thu, 19 Jan 2012 18:26:02 +0000 [thread overview]
Message-ID: <20120119182602.GM3178@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326997456-16296-2-git-send-email-peter.ujfalusi@ti.com>
On Thu, Jan 19, 2012 at 07:24:13PM +0100, Peter Ujfalusi wrote:
> The core implementation applies the msbits constraint to samples
> where it should not.
> Do not ask core to do this, the original code does the right thing.
Peter, grow up. With my last patch (well, a typo fixed version of it)
userspace will do what you want.
next prev parent reply other threads:[~2012-01-19 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 18:24 [PATCH 0/4] ASoC: Do not use core to handle msbits constraint for TI drivers Peter Ujfalusi
2012-01-19 18:24 ` [PATCH 1/4] Revert "ASoC: tlv320dac33: Use core to set the msbits constraint" Peter Ujfalusi
2012-01-19 18:26 ` Mark Brown [this message]
2012-01-19 18:33 ` Peter Ujfalusi
2012-01-19 19:07 ` Mark Brown
2012-01-21 14:05 ` Peter Ujfalusi
2012-01-21 15:20 ` Mark Brown
2012-01-19 18:24 ` [PATCH 2/4] Revert "ASoC: twl4030: " Peter Ujfalusi
2012-01-19 18:24 ` [PATCH 3/4] Revert "ASoC: omap-dmic: " Peter Ujfalusi
2012-01-19 18:24 ` [PATCH 4/4] ASoC: omap-mcpdm: Do not use core to set msbit constraint Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119182602.GM3178@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.