From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock() Date: Thu, 19 Jan 2012 12:53:55 -0800 Message-ID: <20120119205355.GJ5198@google.com> References: <1326958401.1113.22.camel@edumazet-laptop> <1326979818.2249.12.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=UmAMSLrOPnDWCEE7rfPgBNyQ9RFQYL7/2dw8/iiGNvU=; b=M5Pom/ww4uK0Rp2J7s3PlibZQbS+uhLedcTe2OH/bufrSbK63HlkVNh1WuRV4tFG7E 2wShnoiSxGiVRfNQpC3Qdxw6dVSR7CfZXS9LhLj70Mqdo/h7pmwuKJHXKkcKo+4fQG9I /7wx7TAd+8TWajYH8EZ7KC7hF3/qu9ycphJ48= Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hugh Dickins Cc: Eric Dumazet , Li Zefan , Andrew Morton , Manfred Spraul , KAMEZAWA Hiroyuki , Johannes Weiner , Ying Han , Greg Thelen , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote: > Remove lock and unlock around css_get_next()'s call to idr_get_next(). > memcg iterators (only users of css_get_next) already did rcu_read_lock(), > and its comment demands that; but add a WARN_ON_ONCE to make sure of it. > > Signed-off-by: Hugh Dickins > Acked-by: KAMEZAWA Hiroyuki > Acked-by: Li Zefan All three look good to me, Acked-by: Tejun Heo Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx138.postini.com [74.125.245.138]) by kanga.kvack.org (Postfix) with SMTP id 199E46B004F for ; Thu, 19 Jan 2012 15:54:01 -0500 (EST) Received: by iadj38 with SMTP id j38so502352iad.14 for ; Thu, 19 Jan 2012 12:54:00 -0800 (PST) Date: Thu, 19 Jan 2012 12:53:55 -0800 From: Tejun Heo Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock() Message-ID: <20120119205355.GJ5198@google.com> References: <1326958401.1113.22.camel@edumazet-laptop> <1326979818.2249.12.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Eric Dumazet , Li Zefan , Andrew Morton , Manfred Spraul , KAMEZAWA Hiroyuki , Johannes Weiner , Ying Han , Greg Thelen , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote: > Remove lock and unlock around css_get_next()'s call to idr_get_next(). > memcg iterators (only users of css_get_next) already did rcu_read_lock(), > and its comment demands that; but add a WARN_ON_ONCE to make sure of it. > > Signed-off-by: Hugh Dickins > Acked-by: KAMEZAWA Hiroyuki > Acked-by: Li Zefan All three look good to me, Acked-by: Tejun Heo Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933061Ab2ASUyC (ORCPT ); Thu, 19 Jan 2012 15:54:02 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:43812 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932718Ab2ASUyA (ORCPT ); Thu, 19 Jan 2012 15:54:00 -0500 Date: Thu, 19 Jan 2012 12:53:55 -0800 From: Tejun Heo To: Hugh Dickins Cc: Eric Dumazet , Li Zefan , Andrew Morton , Manfred Spraul , KAMEZAWA Hiroyuki , Johannes Weiner , Ying Han , Greg Thelen , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock() Message-ID: <20120119205355.GJ5198@google.com> References: <1326958401.1113.22.camel@edumazet-laptop> <1326979818.2249.12.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote: > Remove lock and unlock around css_get_next()'s call to idr_get_next(). > memcg iterators (only users of css_get_next) already did rcu_read_lock(), > and its comment demands that; but add a WARN_ON_ONCE to make sure of it. > > Signed-off-by: Hugh Dickins > Acked-by: KAMEZAWA Hiroyuki > Acked-by: Li Zefan All three look good to me, Acked-by: Tejun Heo Thanks. -- tejun