From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/lib/format_text archiver.c
Date: 20 Jan 2012 11:01:14 -0000 [thread overview]
Message-ID: <20120120110114.3118.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-01-20 11:01:13
Modified files:
lib/format_text: archiver.c
Log message:
Thin until proper vgcfgrestore for thin is implementad, disable restore.
Since it may probably do more harm to leave it enabled - add extra test
for presence of thin volumes in VG, and in this case disable restore.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/archiver.c.diff?cvsroot=lvm2&r1=1.47&r2=1.48
--- LVM2/lib/format_text/archiver.c 2011/08/10 20:25:30 1.47
+++ LVM2/lib/format_text/archiver.c 2012/01/20 11:01:13 1.48
@@ -348,6 +348,7 @@
{
struct volume_group *vg;
int missing_pvs, r = 0;
+ const struct lv_list *lvl;
/*
* Read in the volume group from the text file.
@@ -355,6 +356,16 @@
if (!(vg = backup_read_vg(cmd, vg_name, file)))
return_0;
+ /* FIXME: Restore support is missing for now */
+ dm_list_iterate_items(lvl, &vg->lvs)
+ if (lv_is_thin_type(lvl->lv)) {
+ log_error("Cannot restore Volume Group %s with "
+ "thin logical volumes. "
+ "(not yet supported).", vg->name);
+ r = 0;
+ goto out;
+ }
+
missing_pvs = vg_missing_pv_count(vg);
if (missing_pvs == 0)
r = backup_restore_vg(cmd, vg);
@@ -362,6 +373,7 @@
log_error("Cannot restore Volume Group %s with %i PVs "
"marked as missing.", vg->name, missing_pvs);
+out:
release_vg(vg);
return r;
}
next reply other threads:[~2012-01-20 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 11:01 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-28 20:50 LVM2/lib/format_text archiver.c mbroz
2011-01-05 15:06 zkabelac
2010-06-29 15:04 wysochanski
2009-05-19 9:45 mbroz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120110114.3118.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.