All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 12/39] hwmon: (f71805f) Fix checkpatch issues
Date: Fri, 20 Jan 2012 15:03:11 +0000	[thread overview]
Message-ID: <20120120150311.GC353@ericsson.com> (raw)
In-Reply-To: <1326703781-14272-13-git-send-email-linux@roeck-us.net>

On Fri, Jan 20, 2012 at 08:33:46AM -0500, Jean Delvare wrote:
> On Mon, 16 Jan 2012 00:49:14 -0800, Guenter Roeck wrote:
> > Fixed:
> > ERROR: code indent should use tabs where possible
> > ERROR: do not use assignment in if condition
> > ERROR: "foo* bar" should be "foo *bar"
> > ERROR: need consistent spacing around '|' (ctx:VxW)
> > WARNING: simple_strtol is obsolete, use kstrtol instead
> > WARNING: simple_strtoul is obsolete, use kstrtoul instead
> > WARNING: static const char * array should probably be static const char * const
> > 
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >  drivers/hwmon/f71805f.c |  163 ++++++++++++++++++++++++++++++++++-------------
> >  1 files changed, 118 insertions(+), 45 deletions(-)
> >
> > diff --git a/drivers/hwmon/f71805f.c b/drivers/hwmon/f71805f.c
> > index 92f9497..859b203 100644
> > --- a/drivers/hwmon/f71805f.c
> > +++ b/drivers/hwmon/f71805f.c
> > (...)
> 
> Looks OK, tested without problems.
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> I noticed an unrelated bug during my testing, I'll investigate it and
> send a fix.
> 
Great .. a positive unintended side effect ;).

Thanks!
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2012-01-20 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16  8:49 [lm-sensors] [PATCH 12/39] hwmon: (f71805f) Fix checkpatch issues Guenter Roeck
2012-01-20 13:33 ` Jean Delvare
2012-01-20 15:03 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120120150311.GC353@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.