All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: Ben Dooks <ben-linux@fluff.org>, linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] i2c: OMAP: Fix OMAP1 build error
Date: Fri, 20 Jan 2012 08:22:46 -0800	[thread overview]
Message-ID: <20120120162245.GN22818@atomide.com> (raw)
In-Reply-To: <4F198E58.4070509@ti.com>

* Cousson, Benoit <b-cousson@ti.com> [120120 07:22]:
> CONFIG_OF is not defined for OMAP1 yet and thus the omap1_defconfig build
> generate an error for 3.3-rc1.
> 
> drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe':
> drivers/i2c/busses/i2c-omap.c:1021:26: error: 'omap_i2c_of_match' undeclared (first use in this function)
> drivers/i2c/busses/i2c-omap.c:1021:26: note: each undeclared identifier is reported only once for each function it appears in
> 
> Wrap omap_i2c_of_match with of_match_ptr() to prevent compilation error in case of OMAP1 build.
> 
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Ben Dooks <ben-linux@fluff.org>

Thanks, Ben care to ack this one? I'd like to apply it into
my fixes branch so I can compile and boot test all the
following fixes without having to apply this fix every
time I compile ;)

Regards,

Tony

> ---
>  drivers/i2c/busses/i2c-omap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index f713eac..801df60 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1018,7 +1018,7 @@ omap_i2c_probe(struct platform_device *pdev)
>  		goto err_release_region;
>  	}
>  
> -	match = of_match_device(omap_i2c_of_match, &pdev->dev);
> +	match = of_match_device(of_match_ptr(omap_i2c_of_match), &pdev->dev);
>  	if (match) {
>  		u32 freq = 100000; /* default to 100000 Hz */
>  
> -- 
> 1.7.0.4
> 

      reply	other threads:[~2012-01-20 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 15:55 [PATCH] i2c: OMAP: Fix OMAP1 build error Cousson, Benoit
2012-01-20 16:22 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120120162245.GN22818@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.