From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] dma-buf: Use EXPORT_SYMBOL Date: Fri, 20 Jan 2012 13:12:41 -0500 Message-ID: <20120120181241.GA8335@phenom.dumpdata.com> References: <1326845297-6233-1-git-send-email-rmorell@nvidia.com> <1326845297-6233-2-git-send-email-rmorell@nvidia.com> <20120120180457.GE29824@morell.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20120120180457.GE29824@morell.nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Robert Morell Cc: "Semwal, Sumit" , Arnd Bergmann , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , "sumit.semwal@linaro.org" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Fri, Jan 20, 2012 at 10:04:57AM -0800, Robert Morell wrote: > On Wed, Jan 18, 2012 at 01:10:04AM -0800, Semwal, Sumit wrote: > > On Wed, Jan 18, 2012 at 5:38 AM, Robert Morell = wrote: > > > EXPORT_SYMBOL_GPL is intended to be used for "an internal impleme= ntation > > > issue, and not really an interface". =A0The dma-buf infrastructur= e is > > > explicitly intended as an interface between modules/drivers, so i= t > > > should use EXPORT_SYMBOL instead. > >=20 > > + Konrad, Arnd, Mauro: there were strong objections on using > > EXPORT_SYMBOL in place of EXPORT_SYMBOL_GPL by all 3 of them; I I am going to defer to what David Airlie recommends. > > suggest we first arrive at a consensus before merging this patch. >=20 > This discussion seems to have stagnated; how do we move forward here? >=20 > Sumit, as the primary author and new maintainer (congrats!) of the > dma-buf infrastructure, it seems like it's really your call how to > proceed. I'd still like to see this be something that we can use fro= m > the nvidia and fglrx drivers for Xorg buffer sharing, as I and Dave h= ave > argued in this thread. It really seems to me that this change on a > technical level won't have any adverse effect on the scenarios where = it > can be used today, but it will allow it to be used more widely, which > will prevent duplication and fragmentation in the future and be great= ly > appreciated by users of hardware such as Optimus. >=20 > Let me know if you have any questions. >=20 > Thanks, > Robert