From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: Add support for multiple s5m devices
Date: Fri, 20 Jan 2012 18:23:04 +0000 [thread overview]
Message-ID: <20120120182303.GA18762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327043352-25037-2-git-send-email-sbkim73@samsung.com>
On Fri, Jan 20, 2012 at 04:09:12PM +0900, Sangbeom Kim wrote:
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + switch (s5m87xx->device_type) {
> + case S5M8751X:
> + ret = mfd_add_devices(s5m87xx->dev, -1, s5m8751_devs,
> + ARRAY_SIZE(s5m8751_devs), NULL, 0);
> + break;
Does the hardware have ID registers you can use to confirm if the user
got the right device? Cut'n'pasting of machine definitions can be a bit
error prone.
next prev parent reply other threads:[~2012-01-20 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 7:09 [PATCH 1/2] mfd: Convert s5m core driver to use devm_kzalloc() Sangbeom Kim
2012-01-20 7:09 ` [PATCH 2/2] mfd: Add support for multiple s5m devices Sangbeom Kim
2012-01-20 18:23 ` Mark Brown [this message]
2012-02-20 16:54 ` Samuel Ortiz
2012-02-20 16:52 ` [PATCH 1/2] mfd: Convert s5m core driver to use devm_kzalloc() Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120182303.GA18762@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.