From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Reilly Subject: Re: mc13xxx: add I2C support Date: Fri, 20 Jan 2012 18:55:35 +1100 Message-ID: <201201201855.35971.marc@cpdesign.com.au> References: <1326934894-29516-1-git-send-email-marc@cpdesign.com.au> <87lip4kktc.fsf@lebrac.rtp-net.org> <20120119112941.GC29494@sirena.org.uk> Reply-To: marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120119112941.GC29494-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org Cc: Arnaud Patard , Mark Brown , mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi, Thankyou all for your feedback and comments. I'll use them for a V2 but Samuel, I'd like to know if you'd like me to base them on a specific branch before I do. Shawn, thanks for testing! On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote: > On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote: > > I've never looked at regmap deeply but can't it be done with regmap or is > > it just a bad idea ? > > Glancing quickly at the existing code it should map on reasonably well, > though a new format definition may be required for the 25 bit shift that > would be trivial. I'm sadly unfamiliar with regmap, is it a far superior solution? does it need to used now? (ie. I'm relucant to totally rework this now. Please convince me I need to if required.) Cheers, Marc ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d