diff for duplicates of <20120121000913.GA3089@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 1ce1dc8..c7333d4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -293,7 +293,8 @@ At least then it would be more obvious that this is what you are doing. > > > + struct device_attribute *devattr, > > > char *buf) +{ > > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev); -> > > + struct sensor_device_attribute_2 *attr > > > to_sensor_dev_attr_2(devattr); +> > > + struct sensor_device_attribute_2 *attr = +> > > to_sensor_dev_attr_2(devattr); > > > + int is_min = attr->nr != 0; > > > + int polarity, range; > > > + @@ -321,7 +322,8 @@ At least then it would be more obvious that this is what you are doing. > > > + const char *buf, size_t count) > > > +{ > > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev); -> > > + struct sensor_device_attribute_2 *attr > > > to_sensor_dev_attr_2(devattr); +> > > + struct sensor_device_attribute_2 *attr = +> > > to_sensor_dev_attr_2(devattr); > > > + int is_min = attr->nr != 0; > > > + int range1 = ts5500_adc_range(chip, is_min, 0, 0); > > > + int range2 = ts5500_adc_range(chip, is_min, 1, 1); @@ -362,7 +364,8 @@ At least then it would be more obvious that this is what you are doing. > > > + char *buf) > > > +{ > > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev); -> > > + struct sensor_device_attribute *attr > > > to_sensor_dev_attr(devattr); +> > > + struct sensor_device_attribute *attr = +> > > to_sensor_dev_attr(devattr); > > > + int polarity, range; > > > + int ret; > > > + u8 command; @@ -480,11 +483,12 @@ Maybe just add a note in the version change log that this is a false positive. > > > + > > > +static int __devinit ts5500_adc_probe(struct platform_device *pdev) > > > +{ -> > > + struct ts5500_adc_platform_data *pdata > > > pdev->dev.platform_data; +> > > + struct ts5500_adc_platform_data *pdata = +> > > pdev->dev.platform_data; > > > + struct ts5500_adc_chip *chip; > > > + int ret; > > > + -> > > + if (pdata = NULL) +> > > + if (pdata == NULL) > > > + return -ENODEV; > > > + > > > + chip = kzalloc(sizeof *chip, GFP_KERNEL); @@ -680,8 +684,3 @@ Maybe just add a note in the version change log that this is a false positive. > Vivien Didelot > Savoir-faire Linux Inc. > Tel: (514) 276-5468 #149 - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 9e8bb1a..48bd303 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\020120119025549.GA20804@ericsson.com\0" "ref\020120120184150.3f0050a8@v0nbox\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH v4 4/4] x86/platform: (TS-5500) add ADC support\0" - "Date\0Sat, 21 Jan 2012 00:09:13 +0000\0" + "Subject\0Re: [PATCH v4 4/4] x86/platform: (TS-5500) add ADC support\0" + "Date\0Fri, 20 Jan 2012 16:09:13 -0800\0" "To\0Vivien Didelot <vivien.didelot@savoirfairelinux.com>\0" "Cc\0x86@kernel.org <x86@kernel.org>" Jonas Fonseca <jonas.fonseca@savoirfairelinux.com> @@ -310,7 +310,8 @@ "> > > + struct device_attribute *devattr,\n" "> > > char *buf) +{\n" "> > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev);\n" - "> > > + struct sensor_device_attribute_2 *attr > > > to_sensor_dev_attr_2(devattr);\n" + "> > > + struct sensor_device_attribute_2 *attr =\n" + "> > > to_sensor_dev_attr_2(devattr);\n" "> > > + int is_min = attr->nr != 0;\n" "> > > + int polarity, range;\n" "> > > +\n" @@ -338,7 +339,8 @@ "> > > + const char *buf, size_t count)\n" "> > > +{\n" "> > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev);\n" - "> > > + struct sensor_device_attribute_2 *attr > > > to_sensor_dev_attr_2(devattr);\n" + "> > > + struct sensor_device_attribute_2 *attr =\n" + "> > > to_sensor_dev_attr_2(devattr);\n" "> > > + int is_min = attr->nr != 0;\n" "> > > + int range1 = ts5500_adc_range(chip, is_min, 0, 0);\n" "> > > + int range2 = ts5500_adc_range(chip, is_min, 1, 1);\n" @@ -379,7 +381,8 @@ "> > > + char *buf)\n" "> > > +{\n" "> > > + struct ts5500_adc_chip *chip = ts5500_adc_get_drvdata(dev);\n" - "> > > + struct sensor_device_attribute *attr > > > to_sensor_dev_attr(devattr);\n" + "> > > + struct sensor_device_attribute *attr =\n" + "> > > to_sensor_dev_attr(devattr);\n" "> > > + int polarity, range;\n" "> > > + int ret;\n" "> > > + u8 command;\n" @@ -497,11 +500,12 @@ "> > > +\n" "> > > +static int __devinit ts5500_adc_probe(struct platform_device *pdev)\n" "> > > +{\n" - "> > > + struct ts5500_adc_platform_data *pdata > > > pdev->dev.platform_data;\n" + "> > > + struct ts5500_adc_platform_data *pdata =\n" + "> > > pdev->dev.platform_data;\n" "> > > + struct ts5500_adc_chip *chip;\n" "> > > + int ret;\n" "> > > +\n" - "> > > + if (pdata = NULL)\n" + "> > > + if (pdata == NULL)\n" "> > > + return -ENODEV;\n" "> > > +\n" "> > > + chip = kzalloc(sizeof *chip, GFP_KERNEL);\n" @@ -696,11 +700,6 @@ "> --\n" "> Vivien Didelot\n" "> Savoir-faire Linux Inc.\n" - "> Tel: (514) 276-5468 #149\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > Tel: (514) 276-5468 #149 -6fc7407b8273d47956378b133ea0b3412e5818f083a82fb13e14a5e8b0d0e9cc +796bbe6176e35d977f0d8e37095b9b48008deacefc0a197d02c851cf13d427c8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.