From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kashyap Gada <gada.kashyap@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, dima@android.com,
jgennis@google.com, rebecca@android.com
Subject: Re: [PATCH 6/6] Staging: android: Add parenthesis to macros with complex values in pmem.c
Date: Sat, 21 Jan 2012 11:24:16 +0300 [thread overview]
Message-ID: <20120121082416.GM3294@mwanda> (raw)
In-Reply-To: <1327119812-19851-1-git-send-email-gada.kashyap@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 471 bytes --]
On Sat, Jan 21, 2012 at 04:23:32AM +0000, Kashyap Gada wrote:
> -#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
> -#define PMEM_ORDER(id, index) pmem[id].bitmap[index].order
> +#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
> +#define PMEM_ORDER(id, index) (pmem[id].bitmap[index].order)
These are not needed. We're modifying checkpatch.pl to not complain
about these, but it hasn't been merged yet.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-21 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 4:23 [PATCH 6/6] Staging: android: Add parenthesis to macros with complex values in pmem.c Kashyap Gada
2012-01-21 8:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121082416.GM3294@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dima@android.com \
--cc=gada.kashyap@gmail.com \
--cc=gregkh@suse.de \
--cc=jgennis@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rebecca@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.