From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()
Date: Sat, 21 Jan 2012 17:57:14 +0000 [thread overview]
Message-ID: <20120121175714.GD20505@sirena.org.uk> (raw)
In-Reply-To: <4F1AE36E.3070403@gmail.com>
On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote:
> > - i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL);
> > + i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL);
> Just in case you are resending the patch for any other reason, it might be worth
> to change to sizeof(*i2c) for consistency.
Consistency with...?
TBH I'd rather not change the coding style as well as presumably Ben
likes that the way it is.
next prev parent reply other threads:[~2012-01-21 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 13:28 [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc() Mark Brown
2012-01-21 15:59 ` Sylwester Nawrocki
[not found] ` <1327152527-11364-1-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-21 13:28 ` [PATCH 2/2] i2c-s3c2410: Add stub runtime power management Mark Brown
2012-01-21 15:52 ` Sylwester Nawrocki
2012-01-21 18:31 ` Mark Brown
2012-01-21 20:38 ` Sylwester Nawrocki
[not found] ` <4F1B2235.4000009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-21 21:23 ` Mark Brown
2012-01-21 21:23 ` Heiko Stübner
2012-01-21 21:33 ` Sylwester Nawrocki
[not found] ` <4F1B2F38.9050708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-21 21:57 ` Mark Brown
2012-01-21 22:49 ` Sylwester Nawrocki
2012-01-21 23:10 ` Mark Brown
[not found] ` <1327152527-11364-2-git-send-email-broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-02-13 23:39 ` Ben Dooks
2012-01-21 16:10 ` [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc() Sylwester Nawrocki
2012-01-21 17:57 ` Mark Brown [this message]
2012-01-21 18:27 ` Sylwester Nawrocki
[not found] ` <4F1B0394.8050003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-21 18:36 ` Mark Brown
[not found] ` <4F1AE36E.3070403-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-13 23:38 ` Ben Dooks
2012-02-14 13:03 ` Shubhrajyoti Datta
2012-02-14 13:52 ` Sylwester Nawrocki
2012-01-29 5:14 ` Barry Song
-- strict thread matches above, loose matches on Subject: below --
2011-12-05 14:06 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121175714.GD20505@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.