From: NeilBrown <neilb@suse.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: "Kwolek, Adam" <adam.kwolek@intel.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"kay@redhat.com" <kay@redhat.com>,
"harald@redhat.com" <harald@redhat.com>,
"lpoetter@redhat.com" <lpoetter@redhat.com>,
"mschmidt@redhat.com" <mschmidt@redhat.com>
Subject: Re: [PATCH 2/4] Add --initrd argument to mdadm
Date: Sun, 22 Jan 2012 22:20:38 +1100 [thread overview]
Message-ID: <20120122222038.659c34fb@notabene.brown> (raw)
In-Reply-To: <4F1974AA.4050801@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On Fri, 20 Jan 2012 15:05:30 +0100 Jes Sorensen <Jes.Sorensen@redhat.com>
wrote:
> On 01/19/12 08:25, Kwolek, Adam wrote:
> >>> If there is already a --freeze-reshape option, then I think it is
> >>> > > better to have the boot scripts set that explicitly. The initramfs
> >>> > > stage isn't really something we expect users or admins to mess with
> >>> > > manually, so it ought to work for that. However if there is no option
> >>> > > for this, and I just need to set the variable when detecting --initrd,
> >>> > > then I can add that to the patchset no problem.
> >> >
> >> > I guess I should add here, that I am not strongly opposed to setting
> >> > freeze_reshape for initrd. I am just wary of setting multiple flags magically
> >> > without it being obvious to the user/admin.
> >> >
> >> > Cheers,
> >> > Jes
> > Up to you.
>
> Ok, I will leave it up to Neil/Kay/Harald - what do you guys think?
> Should we make --initrd set the freeze_reshape flag, or better to expect
> the initramfs scripts to specify it directly?
>
I would like to keep these two options separate.
It might be worth noting in the man page that --freeze-reshape would normally
be used with --whatever-we-call-the-new-flag, but I don't think they should
be the same option.
thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-01-22 11:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 10:48 [PATCH 0/4] add --initrd argument to mdadm/mdmon Jes.Sorensen
2012-01-17 10:48 ` [PATCH 1/4] mdmon: Use getopt_long() to parse command line options Jes.Sorensen
2012-01-17 10:48 ` [PATCH 2/4] Add --initrd argument to mdadm Jes.Sorensen
2012-01-18 8:13 ` Kwolek, Adam
2012-01-18 10:08 ` Jes Sorensen
2012-01-18 10:36 ` Kwolek, Adam
2012-01-18 16:43 ` Jes Sorensen
2012-01-18 16:46 ` Jes Sorensen
2012-01-19 7:25 ` Kwolek, Adam
2012-01-20 14:05 ` Jes Sorensen
2012-01-22 11:20 ` NeilBrown [this message]
2012-01-22 11:17 ` NeilBrown
2012-01-23 10:25 ` Jes Sorensen
2012-01-23 20:13 ` Lennart Poettering
2012-01-23 20:50 ` Kay Sievers
2012-01-25 10:53 ` Jes Sorensen
2012-01-25 11:37 ` NeilBrown
2012-01-25 13:34 ` Jes Sorensen
2012-01-17 10:48 ` [PATCH 3/4] Add --initrd argument to mdmon Jes.Sorensen
2012-01-22 11:22 ` NeilBrown
2012-01-23 10:27 ` Jes Sorensen
2012-01-17 10:48 ` [PATCH 4/4] Spawn mdmon with --initrd if mdadm was launched with --initrd Jes.Sorensen
2012-01-17 19:57 ` [PATCH 0/4] add --initrd argument to mdadm/mdmon Doug Ledford
2012-01-17 20:16 ` Jes Sorensen
2012-01-22 11:25 ` NeilBrown
2012-01-21 1:27 ` Lennart Poettering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120122222038.659c34fb@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=adam.kwolek@intel.com \
--cc=dledford@redhat.com \
--cc=harald@redhat.com \
--cc=kay@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=lpoetter@redhat.com \
--cc=mschmidt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.