From: Lubos Kolouch <lubos.kolouch@gmail.com>
To: Keith Packard <keithp@keithp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: i915 wakes from suspend to RAM with blank screen after commit cd9dde44f47501394b9f0715b6a36a92aa74c0d0
Date: Mon, 23 Jan 2012 07:33:14 +0100 [thread overview]
Message-ID: <20120123063313.GA2113@nbgentoo> (raw)
In-Reply-To: <867h0j83vx.fsf@sumi.keithp.com>
On Sun, Jan 22, 2012, 20:00:18, Keith Packard wrote:
> On Sun, 22 Jan 2012 11:29:12 +0100, Lubos Kolouch <lubos.kolouch@gmail.com> wrote:
>
> > Thanks, here you go:
> > dmesg after boot - http://paste.pocoo.org/show/538625/
> > dmesg after failed resume - http://paste.pocoo.org/show/538626/
>
> Ok, looks like my theory is correct. We're fitting a 24bpp mode to an
> 18bpp data rate, which doesn't work.
>
> I'm in the middle of bisecting a bluetooth failure in 3.3-rc1, so I
> don't have a working kernel at present, but here's a section of
> intel_dp.c in the intel_dp_mode_fixup function:
>
> int max_clock = intel_dp_max_link_bw(intel_dp) == DP_LINK_BW_2_7 ? 1 : 0;
> - int bpp = mode->private_flags & INTEL_MODE_DP_FORCE_6BPC ? 18 : 0;
> + int bpp = mode->private_flags & INTEL_MODE_DP_FORCE_6BPC ? 18 : 24;
> static int bws[2] = { DP_LINK_BW_1_62, DP_LINK_BW_2_7 };
>
> (this is completely hand-generated, so 'patch' will almost certainly not work)
>
> This will force it to use the correct bpp when computing the bandwidth
> used by the new mode. This should fix your problem. If so, I'll have a
> larger patch which stops the underlying function from (almost always
> incorrectly) using the current bpp when computing bandwidth.
>
> --
> keith.packard@intel.com
Thanks, I applied it and it seems to solve the issue!
dmesg after boot - http://paste.pocoo.org/show/539115/
dmesg after OK resume - http://paste.pocoo.org/show/539117/
Lubos
next prev parent reply other threads:[~2012-01-23 6:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 10:32 i915 wakes from suspend to RAM with blank screen after commit cd9dde44f47501394b9f0715b6a36a92aa74c0d0 Lubos Kolouch
2012-01-21 18:15 ` Keith Packard
2012-01-21 18:44 ` Lubos Kolouch
2012-01-21 20:53 ` Keith Packard
2012-01-22 10:29 ` Lubos Kolouch
2012-01-23 4:00 ` Keith Packard
2012-01-23 6:33 ` Lubos Kolouch [this message]
2012-01-26 7:37 ` Keith Packard
2012-01-27 10:14 ` Lubos Kolouch
2012-01-27 18:57 ` Keith Packard
2012-01-31 22:39 ` Joseph Salisbury
2012-02-07 2:31 ` Keith Packard
2012-01-21 18:51 ` Lubos Kolouch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123063313.GA2113@nbgentoo \
--to=lubos.kolouch@gmail.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.