From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] pv drivers: wrap xen_cpuid_base() Date: Mon, 23 Jan 2012 15:22:32 +0100 Message-ID: <20120123142232.GA8983@aepfle.de> References: <88bddf1f0bafade64316.1327326599@probook.site> <4F1D786A020000780006E6D1@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F1D786A020000780006E6D1@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Jan 23, Jan Beulich wrote: > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38) > > Given that the PV drivers must be building fine for SLE11 SP2, which > is 3.0-based, I wonder if this really is the correct fix (and doesn't > rather break the build). The first thing coming to mind is that > arch/x86/include/asm/xen/hypervisor.h shouldn't get included here > (and hence there shouldn't be any conflict). Are you perhaps trying > to build the PV drivers against a pv-ops-enabled configuration (which > is a wrong to try afaict)? Its an ordinary kernel-source tree. git describe d9b8ca8474fd4fdd43ba6d97a4fee8b49b978067 v2.6.37-rc5-2-gd9b8ca8 The function appears in 2.6.38, so I think the version number is correct. Olaf