diff for duplicates of <20120124083347.GC1660@cmpxchg.org> diff --git a/a/1.txt b/N1/1.txt index 70a40f9..760bae5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,25 +10,25 @@ On Mon, Jan 23, 2012 at 08:30:42PM +0800, Hillf Danton wrote: > >> Signed-off-by: Hillf Danton <dhillf@gmail.com> > >> --- > >> -> >> --- a/mm/vmscan.c Mon Jan 23 00:23:10 2012 -> >> +++ b/mm/vmscan.c Mon Jan 23 09:57:20 2012 +> >> --- a/mm/vmscan.c Mon Jan 23 00:23:10 2012 +> >> +++ b/mm/vmscan.c Mon Jan 23 09:57:20 2012 > >> @@ -2086,6 +2086,7 @@ static void shrink_mem_cgroup_zone(int p -> >> unsigned long nr_reclaimed, nr_scanned; -> >> unsigned long nr_to_reclaim = sc->nr_to_reclaim; -> >> struct blk_plug plug; -> >> + bool memcg_over_reclaimed = false; +> >> unsigned long nr_reclaimed, nr_scanned; +> >> unsigned long nr_to_reclaim = sc->nr_to_reclaim; +> >> struct blk_plug plug; +> >> + bool memcg_over_reclaimed = false; > >> -> >> restart: -> >> nr_reclaimed = 0; +> >> restart: +> >> nr_reclaimed = 0; > >> @@ -2103,6 +2104,11 @@ restart: > >> -> >> nr_reclaimed += shrink_list(lru, nr_to_scan, -> >> mz, sc, priority); +> >> nr_reclaimed += shrink_list(lru, nr_to_scan, +> >> mz, sc, priority); > >> + -> >> + memcg_over_reclaimed = !scanning_global_lru(mz) -> >> + && (nr_reclaimed >= nr_to_reclaim); -> >> + if (memcg_over_reclaimed) -> >> + goto out; +> >> + memcg_over_reclaimed = !scanning_global_lru(mz) +> >> + && (nr_reclaimed >= nr_to_reclaim); +> >> + if (memcg_over_reclaimed) +> >> + goto out; > > > > Since this merge window, scanning_global_lru() is always false when > > the memory controller is enabled, i.e. most common configurations and @@ -56,10 +56,3 @@ Overreclaim is absolutely horrible with soft limits, but I think there are more direct reasons than checking nr_to_reclaim only after a full zone scan, for example, soft limit reclaim is invoked on zones that are totally fine. - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 707a5bf..bcb612c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -26,25 +26,25 @@ "> >> Signed-off-by: Hillf Danton <dhillf@gmail.com>\n" "> >> ---\n" "> >>\n" - "> >> --- a/mm/vmscan.c Mon Jan 23 00:23:10 2012\n" - "> >> +++ b/mm/vmscan.c Mon Jan 23 09:57:20 2012\n" + "> >> --- a/mm/vmscan.c \302\240 \302\240 Mon Jan 23 00:23:10 2012\n" + "> >> +++ b/mm/vmscan.c \302\240 \302\240 Mon Jan 23 09:57:20 2012\n" "> >> @@ -2086,6 +2086,7 @@ static void shrink_mem_cgroup_zone(int p\n" - "> >> unsigned long nr_reclaimed, nr_scanned;\n" - "> >> unsigned long nr_to_reclaim = sc->nr_to_reclaim;\n" - "> >> struct blk_plug plug;\n" - "> >> + bool memcg_over_reclaimed = false;\n" + "> >> \302\240 \302\240 \302\240 unsigned long nr_reclaimed, nr_scanned;\n" + "> >> \302\240 \302\240 \302\240 unsigned long nr_to_reclaim = sc->nr_to_reclaim;\n" + "> >> \302\240 \302\240 \302\240 struct blk_plug plug;\n" + "> >> + \302\240 \302\240 bool memcg_over_reclaimed = false;\n" "> >>\n" - "> >> restart:\n" - "> >> nr_reclaimed = 0;\n" + "> >> \302\240restart:\n" + "> >> \302\240 \302\240 \302\240 nr_reclaimed = 0;\n" "> >> @@ -2103,6 +2104,11 @@ restart:\n" "> >>\n" - "> >> nr_reclaimed += shrink_list(lru, nr_to_scan,\n" - "> >> mz, sc, priority);\n" + "> >> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 nr_reclaimed += shrink_list(lru, nr_to_scan,\n" + "> >> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 mz, sc, priority);\n" "> >> +\n" - "> >> + memcg_over_reclaimed = !scanning_global_lru(mz)\n" - "> >> + && (nr_reclaimed >= nr_to_reclaim);\n" - "> >> + if (memcg_over_reclaimed)\n" - "> >> + goto out;\n" + "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 memcg_over_reclaimed = !scanning_global_lru(mz)\n" + "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 && (nr_reclaimed >= nr_to_reclaim);\n" + "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (memcg_over_reclaimed)\n" + "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 goto out;\n" "> >\n" "> > Since this merge window, scanning_global_lru() is always false when\n" "> > the memory controller is enabled, i.e. most common configurations and\n" @@ -71,13 +71,6 @@ "Overreclaim is absolutely horrible with soft limits, but I think there\n" "are more direct reasons than checking nr_to_reclaim only after a full\n" "zone scan, for example, soft limit reclaim is invoked on zones that\n" - "are totally fine.\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + are totally fine. -4cb76fcd605ad5ab9857065d3f7d56bdae016e4e9a217725678780bfd92fff0a +7c39519603c6c4e669f017fab202ad8f65b23aa1e4227e3f1a008e47df93f9db
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.