diff for duplicates of <20120124083922.GA29097@elgon.mountain> diff --git a/a/1.txt b/N1/1.txt index 889fb94..2f4836b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ We should just return directly here, the goto causes a NULL dereference. -Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 986709a..026d646 100644 @@ -10,11 +10,11 @@ index 986709a..026d646 100644 struct smb_vol *vol_info; vol_info = kzalloc(sizeof(*vol_info), GFP_KERNEL); -- if (vol_info = NULL) { +- if (vol_info == NULL) { - tcon = ERR_PTR(-ENOMEM); - goto out; - } -+ if (vol_info = NULL) ++ if (vol_info == NULL) + return ERR_PTR(-ENOMEM); vol_info->local_nls = cifs_sb->local_nls; diff --git a/a/content_digest b/N1/content_digest index fe9d0cc..20a6a10 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\0" "Subject\0[patch] cifs: NULL dereference on allocation failure\0" - "Date\0Tue, 24 Jan 2012 08:39:22 +0000\0" + "Date\0Tue, 24 Jan 2012 11:39:22 +0300\0" "To\0Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>\0" "Cc\0linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org @@ -9,7 +9,7 @@ "b\0" "We should just return directly here, the goto causes a NULL dereference.\n" "\n" - "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\n" "\n" "diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c\n" "index 986709a..026d646 100644\n" @@ -19,14 +19,14 @@ " \tstruct smb_vol *vol_info;\n" " \n" " \tvol_info = kzalloc(sizeof(*vol_info), GFP_KERNEL);\n" - "-\tif (vol_info = NULL) {\n" + "-\tif (vol_info == NULL) {\n" "-\t\ttcon = ERR_PTR(-ENOMEM);\n" "-\t\tgoto out;\n" "-\t}\n" - "+\tif (vol_info = NULL)\n" + "+\tif (vol_info == NULL)\n" "+\t\treturn ERR_PTR(-ENOMEM);\n" " \n" " \tvol_info->local_nls = cifs_sb->local_nls;\n" " \tvol_info->linux_uid = fsuid;" -11f790d48be684db83f93ba76649f09524f3a6e636041f87f8192c40da701343 +3ebc94dadb1db9788adcdcf02c0f32a7cadfc9b86ae3463aa14e33e2507bf6cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.