Re: [PATCH BlueZ] Fix memory leak when loading keys

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Lizardo,

On Tue, Jan 24, 2012, Anderson Lizardo wrote:
> On Mon, Jan 23, 2012 at 8:21 PM, Vinicius Costa Gomes
> <vinicius.gomes@openbossa.org> wrote:
> > @@ -3570,7 +3571,16 @@ static int hciops_load_keys(int index, GSList *keys, gboolean debug_keys)
> >        if (dev->keys != NULL)
> >                return -EEXIST;
> >
> > -       dev->keys = keys;
> > +       for (l = keys; l; l = l->next) {
> > +               struct link_key_info *orig, *dup;
> > +
> > +               orig = l->data;
> > +
> > +               dup = g_memdup(orig, sizeof(*orig));
> > +
> > +               dev->keys = g_slist_prepend(dev->keys, dup);
> > +       }
> > +
> 
> No need to cleanup dev->keys first?

Take a look at the first two lines of context. The function bails out if
dev->keys is anything else than NULL.

Johan